Skip to content

Conversation

@jfly
Copy link
Contributor

@jfly jfly commented Apr 13, 2025

(ping @NixOS/nix-formatting)

Note: I'm opening this as a draft because it links to documentation on nix.dev that has not been merged/deployed yet: NixOS/nix.dev#1129

The current example relies upon nixfmt's deprecated tree traversal behavior. The simplest alternative is the new nixfmt-tree wrapper for nixfmt/treefmt.

@github-actions github-actions bot added documentation new-cli Relating to the "nix" command labels Apr 13, 2025
@jfly jfly force-pushed the update-nix_fmt-man-page branch 2 times, most recently from 5b4994a to d4103d0 Compare April 29, 2025 23:01
@jfly jfly marked this pull request as ready for review April 29, 2025 23:01
@jfly jfly requested a review from edolstra as a code owner April 29, 2025 23:01
@jfly
Copy link
Contributor Author

jfly commented Apr 29, 2025

I've updated this to remove the link to nix.dev (which might be going away soon: ). We (@NixOS/nix-formatting) would like to get this merged up so we can do remove the directory traversal logic from nixfmt and do a stable release of nixfmt.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/formatting-team-meeting-2025-04-29/63649/1

The current example relies upon [nixfmt's deprecated tree traversal
behavior](NixOS/nixfmt#240). The simplest
alternative is the new `nixfmt-tree` wrapper for `nixfmt`/`treefmt`.
@Mic92 Mic92 force-pushed the update-nix_fmt-man-page branch from d4103d0 to 6f71d8a Compare May 1, 2025 12:30
@Mic92 Mic92 enabled auto-merge May 1, 2025 12:31
@Mic92 Mic92 added the backport 2.28-maintenance Automatically creates a PR against the branch label May 1, 2025
@Mic92 Mic92 merged commit 9fe3077 into NixOS:master May 1, 2025
11 of 12 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Nix formatting May 1, 2025
mergify bot added a commit that referenced this pull request May 1, 2025
…3014

Update `nix fmt` man page with official formatter example (backport #13014)
@jfly jfly deleted the update-nix_fmt-man-page branch May 1, 2025 15:50
@jfly jfly mentioned this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.28-maintenance Automatically creates a PR against the branch documentation new-cli Relating to the "nix" command

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants