Remove regex from LocalStore::optimisePath_ #14931
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
store
edolstra
reviewed
Jan 6, 2026
Comment on lines
+112
to
+114
| static constexpr std::string_view appContents = ".app/Contents/"; | ||
| auto pos = path.find(appContents); | ||
| if (pos != std::string::npos && pos + appContents.size() < path.size()) { |
Member
There was a problem hiding this comment.
What is the condition appContents.size() < path.size() for? Can't this just be written as
Suggested change
| static constexpr std::string_view appContents = ".app/Contents/"; | |
| auto pos = path.find(appContents); | |
| if (pos != std::string::npos && pos + appContents.size() < path.size()) { | |
| if (path.find(".app/Contents/") != path.end()) { |
Member
Author
There was a problem hiding this comment.
because .+$ assumes there must be at least one more char and I preferred to be very strict about any behavioral changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.