Remove regex from BinaryCacheStore #14933
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
store
Member
|
Same as the other PRs, I think the regex is shorter and more "obviously correct" than the new code. |
Member
Author
|
I didn't measure the performance impact. I'm in favor of regex eradication but I suppose it's up to the project preference. |
Mic92
reviewed
Jan 13, 2026
| }; | ||
|
|
||
| std::regex regex1("^[0-9a-f]{2}$"); | ||
| std::regex regex2("^[0-9a-f]{38}\\.debug$"); |
Member
There was a problem hiding this comment.
in any case, those regexes could be potentially be re-used i.e. using static?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.