Skip to content

Add module to patch ath12k firmware#1711

Open
TwoUnderscorez wants to merge 2 commits intoNixOS:masterfrom
TwoUnderscorez:patch-ath12k-fw
Open

Add module to patch ath12k firmware#1711
TwoUnderscorez wants to merge 2 commits intoNixOS:masterfrom
TwoUnderscorez:patch-ath12k-fw

Conversation

@TwoUnderscorez
Copy link

Description of changes

Added a module that I wrote for myself upon receiving my Qualcomm QCNCM865 WiFi card and discovering that it didn't work out of the box.

For more details please read the readme and this but report on the Kernel's Bugzilla.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@TwoUnderscorez TwoUnderscorez marked this pull request as ready for review December 29, 2025 17:04
@@ -0,0 +1,81 @@
# linux-firmware/ath12k
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you you know any laptop module where this apply? I mainly want to get some basic evaluation coverage for this code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a good example?
I don't know of any laptop that comes with a wifi chip with unsupported device ids as I have a desktop. I did try to plug the module into a few laptops of mine in case it was my desktop motherboard's fault, but all my computers ended up not recognizing this chip exactly the same.
Because the code merely adds the device id you define to the json and doesn't override anything, you could test it on a computer with Qualcomm wifi chip that already works and make sure that it still works when using this module.
Sorry, this is indeed a very quirky module for very quirky hardware, let me know if there is anything else I can do.

Copy link
Member

@Mic92 Mic92 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's time to find an alternative to parsing our README.md table to figure out what needs to be evaluated and instead use flake outputs to import each module into its own nixos configuration. Than your module would be tested automatically.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know that the readme was being parsed automatically.
Is there anything you want me to do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 Do you think this can be merged or is there anything you'd like me to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants