Draft
Conversation
| <article | ||
| class="shadow-sm group relative rounded-lg bg-white p-6 transition-all duration-200 hover:shadow-md" | ||
| > | ||
| <input type="checkbox" id={getToggleAbstractId(paper)} class="peer hidden" /> |
There was a problem hiding this comment.
The checkbox has no label, for screenreader users it could be hard to understand for what perpose this checkox must be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1580 , to address the review comments by @thilobillerbeck.
As of now this should be functionally complete and make the code more maintainable, but I'm not in a hurry to double-check and get it merged due to other projects.
A few other things from the original issue are also still open, but we can decide if we want to address those preemptively or not:
or change the URL.Also, ed6b212 introduced src/content/research/papers.yaml for some reason.
Depending on how that happened it may or may not be easy to switch using content collections based on that file.
I tried that myself, when I was implementing the original issue, and it looked like Astro would not be happy about having all of the collection entries in one file.