Skip to content

Bootstrap governance page#1864

Merged
thilobillerbeck merged 25 commits intomainfrom
governance
Dec 10, 2025
Merged

Bootstrap governance page#1864
thilobillerbeck merged 25 commits intomainfrom
governance

Conversation

@thilobillerbeck
Copy link
Collaborator

@thilobillerbeck thilobillerbeck commented Oct 8, 2025

Convert the values page into something that is more clear about how the projects governance is working.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

🚀 Deployed on https://68e6e018b481173a2c4fcb45--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

🚀 Deployed on https://68e6e18256d26548a93e1a02--nixos-homepage.netlify.app

@thilobillerbeck thilobillerbeck marked this pull request as ready for review October 11, 2025 20:48
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2025

🚀 Deployed on https://68eac3a1dcba6c7b9271a514--nixos-homepage.netlify.app

infinisil
infinisil requested changes Oct 15, 2025
View reviewed changes
infinisil
infinisil requested changes Oct 15, 2025
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions, but looking great otherwise!

djacu
djacu reviewed Oct 15, 2025
View reviewed changes
djacu
djacu approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@djacu djacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left some comments on the suggestions

@nixos-discourse
Copy link

nixos-discourse commented Oct 16, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/sc-meeting-2025-10-15-17-05-utc/70966/1

thilobillerbeck and others added 4 commits October 21, 2025 21:03
@thilobillerbeck @djacu
update team work description
566bea1 
Co-authored-by: Dan Baker <daniel.n.baker@gmail.com>
@thilobillerbeck @infinisil
Update core/src/pages/governance.astro
86915cc 
Co-authored-by: Silvan Mosberger <silvan.mosberger@tweag.io>
@thilobillerbeck @infinisil
Update core/src/pages/governance.astro
a11f944 
Co-authored-by: Silvan Mosberger <silvan.mosberger@tweag.io>
@thilobillerbeck
show team member github => discourse => real name
3a2587f
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

🚀 Deployed on https://68f7dffdb679b0088d76b4dc--nixos-homepage.netlify.app

infinisil
infinisil approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good other than a minor issue!

I'd also like to ping @NixOS/steering to let them know of this

@JulienMalka
Copy link
Member

JulienMalka commented Nov 24, 2025

I don't know exactly why, but right now the page shows the incorrect names for SC members.

roberth
roberth suggested changes Nov 24, 2025
View reviewed changes
@thilobillerbeck
Copy link
Collaborator Author

thilobillerbeck commented Nov 27, 2025

I don't know exactly why, but right now the page shows the incorrect names for SC members.

This has been branched off before the sc teams page has been updated. Since the display of the SC members takes the data from the same source as the sc teams page it is simply using outdated data which will be no problem when main is either merged into this branch or this branch will at some point be merged into main. :)

thilobillerbeck and others added 4 commits November 27, 2025 18:14
@thilobillerbeck @infinisil
Update core/src/pages/governance.astro
17da7e9 
Co-authored-by: Silvan Mosberger <silvan.mosberger@tweag.io>
@thilobillerbeck @infinisil
Update core/src/pages/governance.astro
0d872b9 
Co-authored-by: Silvan Mosberger <silvan.mosberger@tweag.io>
@thilobillerbeck @roberth
Update core/src/pages/governance.astro
000e690 
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@thilobillerbeck @roberth
Update core/src/pages/governance.astro
75ca507 
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
thilobillerbeck and others added 6 commits November 27, 2025 18:16
@thilobillerbeck @roberth
Update core/src/pages/governance.astro
af10865 
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@thilobillerbeck @roberth
Update core/src/pages/governance.astro
94dfc2a 
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@thilobillerbeck @roberth
Update core/src/pages/governance.astro
0898752 
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@thilobillerbeck @roberth
Update core/src/pages/governance.astro
2f35fd7 
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@thilobillerbeck
format
42d0ec3
@thilobillerbeck
Merge branch 'main' into governance
d0fe1ff
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

🚀 Deployed on https://69288cd46d1ec648773240d6--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

🚀 Deployed on https://69288fd4e5f3d9298bb7f6cd--nixos-homepage.netlify.app

cafkafk
cafkafk suggested changes Dec 5, 2025
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit stack is quite messy, I don't know what the norms are for the nixos-homepage, or whether or not you're mainly seeking validation of the content added, but if you're also asking for a technical review, cleaning it up to be tighter would make it much more reviewable.

@thilobillerbeck
Copy link
Collaborator Author

thilobillerbeck commented Dec 5, 2025 •
edited
Loading

@cafkafk I don't know how much a cleaned up commit stack would help you since this is pretty much about the end result and its contents only. This might have been missed but we usually squash our commits at the end with a proper commit message. This is why I do not really care about keeping a clean commit history in these PRs.

cafkafk
cafkafk suggested changes Dec 8, 2025
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I see, here is a final review from my side.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🚀 Deployed on https://6936e1e8bed79e0c3218a573--nixos-homepage.netlify.app

cafkafk
cafkafk approved these changes Dec 9, 2025
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🔥

@thilobillerbeck thilobillerbeck merged commit fb79fca into main Dec 10, 2025
5 checks passed
@thilobillerbeck thilobillerbeck deleted the governance branch December 10, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djacu djacu djacu approved these changes

@infinisil infinisil infinisil approved these changes

+2 more reviewers

@roberth roberth roberth requested changes

@cafkafk cafkafk cafkafk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@thilobillerbeck @nixos-discourse @JulienMalka @roberth @djacu @infinisil @cafkafk