Skip to content

docs: add PR review policy to the README #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

docs: add PR review policy to the README #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,13 @@ We generally try to include a wide range of flakes that could be of interest to
* Programs that are already part of nixpkgs (we prefer you help maintain them there)
* Outdated package or packaging
* Flakes that require `allow-import-from-derivation`

## Contributing patches

* Patches are very welcome!
* You can send a PRs without opening an issue first, but if you're planning significant work it might be good to discuss your ideas beforehand to avoid disappointment later.
* Reviews by people without write access are welcome
* Every PR requires at least one approval by someone (other than the author) with write access. They can either:
* approve and merge immediately
* approve and leave feedback. The author can merge after considering the feedback.
* add comments without approving