This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Conversation
astro
reviewed
Jul 25, 2022
templates/ical.html
Outdated
| {% for page in section.pages -%} | ||
| {% if page.extra.event_start and page.extra.event_end -%} | ||
| BEGIN:VEVENT | ||
| SUMMARY:{{ page.title }} |
There was a problem hiding this comment.
Is this template going to emit HTML entities?
Collaborator
Author
There was a problem hiding this comment.
Thanks, I didn’t notice that. I changed it to not escape it anymore, so it should now include it raw.
astro
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is implemented by making it possible to assign event metadata to an announcement like this:
If it is not a good way to have overlap with the announcement (which has the advantage that they are also visible on the main page), we could also separate it.
The calendar overview page is very simple, because implementing a calendar display from scratch is not very easy.
Since there currently are no calendar events, I added some fake ones to this test deployment: https://dapper-swan-e898e3.netlify.app/