Update rnix 0.12.0 to 0.14.0 with new path lints#197
Merged
philiptaron merged 2 commits intoNixOS:mainfrom Feb 16, 2026
Merged
Conversation
rnix 0.13.0 split the single `Path` AST node into four type-level variants (PathAbs, PathRel, PathHome, PathSearch). Leverage these to give more specific lint errors instead of relying on string-prefix hacks for search paths and falling through to "cannot be resolved" for absolute paths. New problem types: - NPV-127: absolute path expression (e.g. /foo) is not allowed - NPV-128: home-relative path expression (e.g. ~/foo) is not allowed Also updates rowan 0.15.17 → 0.16.1.
Contributor
Author
|
My friend Claude helped me with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rnixfrom 0.12.0 to 0.14.0 androwanfrom 0.15.17 to 0.16.1PathAbs,PathRel,PathHome,PathSearch) instead of string-prefix hacks/foo) are not allowed in nixpkgs~/foo) are not allowed in nixpkgsTest plan
cargo buildcompiles successfullycargo test— all 6 tests passtests/ref-absoluteupdated to expect NPV-127 instead of NPV-124tests/multiple-failuresupdated for the new absolute path messagetests/ref-home-pathadded as new test case for NPV-128tests/ref-nix-pathunchanged (search path detection still works)