Skip to content

hostctl: init at 1.0.14 #100048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timokau merged 1 commit into from
Oct 30, 2020
Merged

hostctl: init at 1.0.14 #100048

timokau merged 1 commit into from
Oct 30, 2020

Conversation

@blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Oct 8, 2020

Motivation for this change

Add hostmanagement to devshell numtide/devshell#28

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@blaggacao
Copy link
Contributor Author

blaggacao commented Oct 8, 2020 •
edited
Loading

Result of nixpkgs-review pr 100048 1

1 package built:
- hostctl
  • checked hostcl --help

@blaggacao

This comment has been minimized.

Sign in to view
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 8, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 8, 2020
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 8, 2020
@ofborg ofborg bot requested a review from kalbasit October 8, 2020 20:13
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 8, 2020
@blaggacao

This comment has been minimized.

Sign in to view
@nixos-discourse
Copy link

nixos-discourse commented Oct 9, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/333

@06kellyjac
Copy link
Member

06kellyjac commented Oct 10, 2020

Result of nixpkgs-review pr 100048 1

1 package built:
  • hostctl

06kellyjac
06kellyjac approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sugar700
sugar700 suggested changes Oct 12, 2020
View reviewed changes
Copy link
Member

@sugar700 sugar700 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init: hostctl at 1.0.14 commit message should be hostctl: init at 1.0.14 instead (package name at beginning)

@06kellyjac
Copy link
Member

06kellyjac commented Oct 12, 2020

Would also be ideal if the Merge commit was removed and the branch was rebased instead

@blaggacao
Copy link
Contributor Author

blaggacao commented Oct 26, 2020

Formalities adressed. Good to merge.

@nixos-discourse
Copy link

nixos-discourse commented Oct 26, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/263

@sugar700
Copy link
Member

sugar700 commented Oct 26, 2020

/status needs_merger

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 27, 2020
@timokau
Copy link
Member

timokau commented Oct 29, 2020

@GrahamcOfBorg eval

Not sure why this isn't happening. Maybe it has something to do with targeting staging.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: cinnamon Desktop environment 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vim Advanced text editor 6.topic: xfce The Xfce Desktop Environment 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Oct 29, 2020
timokau
timokau approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@timokau timokau merged commit ae01350 into NixOS:staging-next Oct 30, 2020
@FRidh
Copy link
Member

FRidh commented Oct 30, 2020

Note this got merged into staging-next.

@vcunat
Copy link
Member

vcunat commented Oct 30, 2020

That was intentional. Context: #100048 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat left review comments

@06kellyjac 06kellyjac 06kellyjac approved these changes

@zowoq zowoq zowoq left review comments

@timokau timokau timokau approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@jonringer jonringer Awaiting requested review from jonringer

@mmahut mmahut Awaiting requested review from mmahut

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@tfc tfc Awaiting requested review from tfc

+1 more reviewer

@sugar700 sugar700 sugar700 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@blaggacao @nixos-discourse @06kellyjac @sugar700 @timokau @FRidh @vcunat @zowoq