craftos-pc: support for darwin

[siraben]

Description of changes

craftos-pc supports darwin as well as indicated in their project, however it requires a few adaptions.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[siraben]

@tomodachi94 would you be able to help look into this? I'm not sure why craftos needs to build its own lua, could it not use Nixpkgs' lua?

[tomodachi94]

I'm not sure why craftos needs to build its own lua, could it not use Nixpkgs' lua?

It could, but iirc ComputerCraft's Lua has some quirks that are not compatible with standard Lua. I'll take a closer look at this when I have more time, probably later tonight or tomorrow :)

(Thanks for making this PR!)

[tomodachi94]

@siraben upon further inspection, CPC has a custom fork of liblua specifically for improved compatibility with the game itself. I don't think that replacing the custom patched Lua for a prebuilt one would work very well with the emulator.

(Maybe the custom Lua should get split out into its own package, liblua-craftos or similar?)

Also, if you rebase onto master, there should be some working tests that ensure this PR's changes work properly on all platforms.

[tomodachi94]

@siraben: the author of CraftOS-PC has some release resources that includes a MacOS icon here; it might be worth taking a look.

[tomodachi94]

@siraben try rebasing your changes on top of master, the tests were broken but they have been fixed.

[tomodachi94]

Lgtm, sorry for taking so long.

[siraben]

Can't merge ATM since it doesn't actually build on macOS yet.

[tomodachi94]

Hopefully this is easier once MCJack123/craftos2#373 is merged.

[tomodachi94]

Diff mostly lgtm, just one smaller thing to avoid unnecessary repetition.

[siraben]

@tomodachi94 let me know what you think

[tomodachi94]

Diff lgtm. Thank you for putting in the effort to make this happen 💖