Conversation
Contributor
|
while I am ok with the changes, I wanted to let you know that while my fork somewhat works, I by now use this lucasrla/remarks#59 to convert new notebook files, which seems more complete. Same as my fork pdf annotations are still broken as no one figured out yet how to transform the annotations correctly ontop of the pdf (at least not to my knowledge). |
Member
Author
Wanna make a PR adding that to Nixpkgs? |
Contributor
|
I can do it on the weekend, however my plan was to wait for an actual release that supports the current version to avoid adding packages to nixpkgs that might get unmaintained soonish |
Member
Author
No need. Feel free to wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.