Skip to content

rmfuse: fix build#283397

Merged
dotlambda merged 3 commits intoNixOS:masterfrom
dotlambda:rmfuse-fix
Jan 28, 2024
Merged

rmfuse: fix build#283397
dotlambda merged 3 commits intoNixOS:masterfrom
dotlambda:rmfuse-fix

Conversation

@dotlambda
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 24, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 24, 2024
@benneti
Copy link
Contributor

benneti commented Jan 24, 2024

while I am ok with the changes, I wanted to let you know that while my fork somewhat works, I by now use this lucasrla/remarks#59 to convert new notebook files, which seems more complete. Same as my fork pdf annotations are still broken as no one figured out yet how to transform the annotations correctly ontop of the pdf (at least not to my knowledge).

@dotlambda
Copy link
Member Author

I by now use this lucasrla/remarks#59 to convert new notebook files, which seems more complete.

Wanna make a PR adding that to Nixpkgs?

@benneti
Copy link
Contributor

benneti commented Jan 24, 2024

I can do it on the weekend, however my plan was to wait for an actual release that supports the current version to avoid adding packages to nixpkgs that might get unmaintained soonish

@dotlambda
Copy link
Member Author

I can do it on the weekend

No need. Feel free to wait.

@dotlambda dotlambda merged commit 542783f into NixOS:master Jan 28, 2024
@dotlambda dotlambda deleted the rmfuse-fix branch January 28, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants