Skip to content

python311Packages.optax: fix build and bump version#300652

Closed
stephen-huan wants to merge 2 commits intoNixOS:masterfrom
stephen-huan:optax-fix
Closed

python311Packages.optax: fix build and bump version#300652
stephen-huan wants to merge 2 commits intoNixOS:masterfrom
stephen-huan:optax-fix

Conversation

@stephen-huan
Copy link
Copy Markdown
Member

Description of changes

2c3b681 (an update from 0.1.7 to 0.2.1) breaks the build as google-deepmind/optax@f0dfdaa removed setup.py in 0.1.9. This PR switches to the pyproject format and also bumps the version. Note that this PR depends on #297146.

Diff: google-deepmind/optax@refs/tags/v0.2.1...v0.2.2

Changelog: https://github.com/deepmind/optax/releases/tag/v0.2.2

cc @mweinelt

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • [] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 1, 2024
@ofborg ofborg bot requested a review from ndl April 1, 2024 10:52
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 1, 2024
@stephen-huan
Copy link
Copy Markdown
Member Author

Superseded by #297146.

@stephen-huan stephen-huan deleted the optax-fix branch April 2, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant