Skip to content

python312Packages.reflex: init at 0.5.9#333337

Merged
pbsds merged 4 commits intoNixOS:masterfrom
pbsds:init-reflex-1723158913
Aug 29, 2024
Merged

python312Packages.reflex: init at 0.5.9#333337
pbsds merged 4 commits intoNixOS:masterfrom
pbsds:init-reflex-1723158913

Conversation

@pbsds
Copy link
Copy Markdown
Member

@pbsds pbsds commented Aug 9, 2024

Description of changes

https://reflex.dev

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 9, 2024
@pbsds pbsds force-pushed the init-reflex-1723158913 branch from f43dd16 to 15869cc Compare August 9, 2024 01:39
@pbsbot
Copy link
Copy Markdown

pbsbot commented Aug 9, 2024

Result of nixpkgs-review pr 333337 run on x86_64-linux 1

16 packages built:
  • python311Packages.reflex
  • python311Packages.reflex-hosting-cli
  • python311Packages.reflex-hosting-cli.dist
  • python311Packages.reflex.dist
  • python311Packages.sqlalchemy-file
  • python311Packages.sqlalchemy-file.dist
  • python311Packages.starlette-admin
  • python311Packages.starlette-admin.dist
  • python312Packages.reflex
  • python312Packages.reflex-hosting-cli
  • python312Packages.reflex-hosting-cli.dist
  • python312Packages.reflex.dist
  • python312Packages.sqlalchemy-file
  • python312Packages.sqlalchemy-file.dist
  • python312Packages.starlette-admin
  • python312Packages.starlette-admin.dist

@pbsds pbsds marked this pull request as ready for review August 9, 2024 01:49
@pbsds pbsds requested a review from natsukium as a code owner August 9, 2024 01:49
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 9, 2024
@pbsds pbsds force-pushed the init-reflex-1723158913 branch from 15869cc to 6ff9b46 Compare August 10, 2024 14:32
@natsukium
Copy link
Copy Markdown
Member

Result of nixpkgs-review pr 333337 at 6ff9b46c run on aarch64-darwin 1

4 packages failed to build:
4 packages built successfully:
  • python311Packages.reflex-hosting-cli
  • python311Packages.sqlalchemy-file
  • python312Packages.reflex-hosting-cli
  • python312Packages.sqlalchemy-file

@natsukium
Copy link
Copy Markdown
Member

The errors seem to be caused by darwin sandbox.

@pbsds
Copy link
Copy Markdown
Member Author

pbsds commented Aug 11, 2024

The errors seem to be caused by darwin sandbox.

this maybe?

--- a/pkgs/development/python-modules/reflex/default.nix
+++ b/pkgs/development/python-modules/reflex/default.nix
@@ -120,10 +120,15 @@ buildPythonPackage rec {
     "test_potentially_dirty_substates"
     # flaky, KeyError: 'reflex___state____state'
     "test_preprocess"
+    # flaky, depends on test order
+    "test_ensuring_pk"
   ];
   disabledTestPaths = [
     "benchmarks/"
     "integration/"
+  ] ++ lib.optionals stdenv.isDarwin [
+    # sandbox issues
+    "tests/sqla/test_sync_engine.py"
   ];
 
   pythonImportsCheck = [ "reflex" ];

btw, which fork do you use to post gists of the logs?

@pbsds pbsds force-pushed the init-reflex-1723158913 branch 2 times, most recently from fe02709 to c1dfc59 Compare August 11, 2024 03:45
@natsukium
Copy link
Copy Markdown
Member

btw, which fork do you use to post gists of the logs?

I use a fork based on this PR.
I would like to submit a PR, but... I haven't yet.

@natsukium
Copy link
Copy Markdown
Member

Result of nixpkgs-review pr 333337 at c1dfc595 run on aarch64-darwin 1

3 packages failed to build:
5 packages built successfully:
  • python311Packages.reflex-hosting-cli
  • python312Packages.reflex
  • python312Packages.reflex-hosting-cli
  • python312Packages.sqlalchemy-file
  • python312Packages.starlette-admin

@pbsds pbsds force-pushed the init-reflex-1723158913 branch from c1dfc59 to 373b592 Compare August 12, 2024 12:15
@pbsds
Copy link
Copy Markdown
Member Author

pbsds commented Aug 12, 2024

not sure what the error might be, but if this doesn't work i might just mark it broken on darwin

@pbsds pbsds force-pushed the init-reflex-1723158913 branch from 373b592 to 1cbded8 Compare August 20, 2024 00:29
@pbsds
Copy link
Copy Markdown
Member Author

pbsds commented Aug 20, 2024

man i dislike darwin, the sandbox is so flaky...

@pbsds pbsds force-pushed the init-reflex-1723158913 branch from 1cbded8 to bc0a29f Compare August 20, 2024 00:30
@pbsds pbsds merged commit 8b088e1 into NixOS:master Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants