boost: Split python module into separate derivation#370251
boost: Split python module into separate derivation#370251tobim wants to merge 3 commits intoNixOS:stagingfrom
Conversation
1349d14 to
bc0aeff
Compare
bc0aeff to
5bf960b
Compare
da3a4ba to
18c2af5
Compare
Is this a convenience, or actually required to deal with some build systems? I would prefer to skip it if the former. I like the idea of splitting it. I wonder if it makes sense to scope it under cc @natsukium as Python maintainer |
There was a problem hiding this comment.
Would be nice to avoid duplication here.
There was a problem hiding this comment.
I'm not so sure. The last 8 are indeed duplicate, but intrucing a b2Args_common indirection would hurt readability and I'd expect them to change very infrequently.
b9af0d9 to
4256b9d
Compare
4256b9d to
9bd119e
Compare
9bd119e to
efe9d80
Compare
Depends on how you define convenience, without that some packages would need to be patched to support boost libs that are spread out across multiple filesystem paths. I believe I only used it for packages that actually need it.
There is actually a |
efe9d80 to
8c8d3a8
Compare
8c8d3a8 to
7be6230
Compare
|
@natsukium @emilazy @SuperSandro2000 I think this is ready. I'd like to get it merged soon. |
3e06f06 to
b558f7e
Compare
b558f7e to
e905697
Compare
8f018da to
6fe0603
Compare
|
I do not know if this falls under a potential breaking change and we still can merge it for the release. |
|
Let's merge this after branch off. |
6fe0603 to
33a2729
Compare
33a2729 to
5714196
Compare
5714196 to
1f50278
Compare
1f50278 to
37cfe00
Compare
37cfe00 to
b3bc76f
Compare
This change replaces the
enablePythonoption from the boost package into a more granular structure whereboost-pythonis a dedicated derivation. This is enabled by 2 new passthru functions from theboostattribute:boost.pythonLib: Takes apythonderivation as a parameter and produces aboost-pythonitself.boost.withPython: Takes apythonderivation as well and produces asymlinkJoin-style derivation containing aboost-pythonlib together with the rest of the boost libraries.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.