Skip to content

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Jan 8, 2025

The error is no longer logged since nextcloud/logreader#1449. This was a bug in the app, since the error is not fixable by the admin due to the logging configuration.

CC @schneefux @bachp @globin @Ma27 @britter

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 8, 2025
@provokateurin provokateurin force-pushed the nixos-nextcloud-remove-obsolete-known-logreader-warning branch from 8815fe1 to 2dd380d Compare January 8, 2025 17:18
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Jan 8, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jan 8, 2025
@provokateurin provokateurin force-pushed the nixos-nextcloud-remove-obsolete-known-logreader-warning branch from 2dd380d to 3b31bee Compare January 8, 2025 17:22
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 8, 2025
@provokateurin
Copy link
Member Author

Alternatively we can also keep the section, as the message is still shown, but only as info and not as an error anymore. Having the section might still be useful for some people to understand why this message appears.

The error is only logged as an info since nextcloud/logreader#1449.
This was a bug in the app, since the error is not fixable by the admin due to the logging configuration.
@provokateurin provokateurin force-pushed the nixos-nextcloud-remove-obsolete-known-logreader-warning branch from 3b31bee to 9683835 Compare January 26, 2025 12:52
@github-actions github-actions bot removed the 8.has: documentation This PR adds or changes documentation label Jan 26, 2025
@provokateurin provokateurin changed the title nixos/nextcloud: Remove obsolete known logreader warning nixos/nextcloud: Update logreader warning description Jan 26, 2025
@provokateurin
Copy link
Member Author

I simply changed the description to match the new behavior, as the "warning" is still shown and admins might want to understand what it means.

@Ma27
Copy link
Member

Ma27 commented Feb 1, 2025

Oof sorry this completely slipped. Taking a look...

@Ma27
Copy link
Member

Ma27 commented Feb 2, 2025

With the last comment resolved, I think we can merge this.
Adding a backport label since the change got backported to nc 28-30 and thus it's also in 24.11, so we can also update its manual.

Originally, I only wanted to remove
"The logreader application doesn't work, as it was the case before.".

But then, the rest sounded a little weird, so I reworded the paragraph a
bit more ;-)
@Ma27
Copy link
Member

Ma27 commented Feb 14, 2025

@provokateurin pushed 9430768. I originally wanted to remove the first sentence only, but then the rest sounded a little weird.

Let me know if you're OK with that change, then I'd merge!
That said, thanks for the upstream work for that in the logreader app :)

@provokateurin
Copy link
Member Author

LGTM

@Ma27 Ma27 merged commit 6c75214 into NixOS:master Feb 14, 2025
26 of 27 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 14, 2025

Successfully created backport PR for release-24.11:

@provokateurin provokateurin deleted the nixos-nextcloud-remove-obsolete-known-logreader-warning branch February 21, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants