-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
nixos/nextcloud: Update logreader warning description #372187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/nextcloud: Update logreader warning description #372187
Conversation
8815fe1 to
2dd380d
Compare
2dd380d to
3b31bee
Compare
|
Alternatively we can also keep the section, as the message is still shown, but only as info and not as an error anymore. Having the section might still be useful for some people to understand why this message appears. |
The error is only logged as an info since nextcloud/logreader#1449. This was a bug in the app, since the error is not fixable by the admin due to the logging configuration.
3b31bee to
9683835
Compare
|
I simply changed the description to match the new behavior, as the "warning" is still shown and admins might want to understand what it means. |
|
Oof sorry this completely slipped. Taking a look... |
|
With the last comment resolved, I think we can merge this. |
Originally, I only wanted to remove "The logreader application doesn't work, as it was the case before.". But then, the rest sounded a little weird, so I reworded the paragraph a bit more ;-)
|
@provokateurin pushed 9430768. I originally wanted to remove the first sentence only, but then the rest sounded a little weird. Let me know if you're OK with that change, then I'd merge! |
|
LGTM |
|
Successfully created backport PR for |
The error is no longer logged since nextcloud/logreader#1449. This was a bug in the app, since the error is not fixable by the admin due to the logging configuration.
CC @schneefux @bachp @globin @Ma27 @britter
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.