Skip to content

gramps: 5.2.4 -> 6.0.1#391563

Merged
natsukium merged 1 commit intoNixOS:masterfrom
TomaSajt:gramps
Jun 14, 2025
Merged

gramps: 5.2.4 -> 6.0.1#391563
natsukium merged 1 commit intoNixOS:masterfrom
TomaSajt:gramps

Conversation

@TomaSajt
Copy link
Copy Markdown
Contributor

https://github.com/gramps-project/gramps/releases

Added orjson python package as a new dependency.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 20, 2025
@nix-owners nix-owners bot requested review from 06kellyjac and pinpox March 20, 2025 12:56
Copy link
Copy Markdown
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise looks good.
I'll try run this with a PR with an existing project when I get a moment

Copy link
Copy Markdown
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import worked fine.
Should probably have a release note item though

@TomaSajt
Copy link
Copy Markdown
Contributor Author

Import worked fine. Should probably have a release note item though

I'm not sure what release note item you're talking about, could you clarify?

@06kellyjac
Copy link
Copy Markdown
Member

From the PR template under "Things Done" above

25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module

Since this is a major version bump (5 -> 6) we should add a note in nixos/doc/manual/release-notes/rl-2505.section.md that people should backup first and outline any breaking changes

@TomaSajt TomaSajt force-pushed the gramps branch 2 times, most recently from 44a4a3b to 62e9177 Compare April 22, 2025 00:02
@TomaSajt TomaSajt changed the title gramps: 5.2.4 -> 6.0.0 gramps: 5.2.4 -> 6.0.1 Apr 22, 2025
@TomaSajt
Copy link
Copy Markdown
Contributor Author

Sorry for the long delay.

In this specific case I don't think it's that necessary to mark the breaking changes in the release notes.
The app itself is helpful and it warns the user about their family tree is using the v20 schema instead of v21, and will have them click on a "I have made a backup, please upgrade my Family Tree" button to continue.

@TomaSajt
Copy link
Copy Markdown
Contributor Author

Though, now that I looked into it, you can only make a backup in a version which still used the older schema version, so the backup should have been made before you upgraded your system.
You could just use the older nixpkgs revision with gramps 5.2.1, but it might be better to warn users in the release notes anyways.

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Apr 22, 2025
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 22, 2025
@TomaSajt
Copy link
Copy Markdown
Contributor Author

Edit: seems like the non release critical package feature freeze was on the 9th, and we missed that.
Seem like we'll have to delay merging this.

@TomaSajt TomaSajt marked this pull request as draft April 24, 2025 00:08
@bemyak bemyak mentioned this pull request May 28, 2025
13 tasks
@bemyak
Copy link
Copy Markdown

bemyak commented May 28, 2025

Since the release is out of the door now, can we proceed with merging this? 🙂

@TomaSajt
Copy link
Copy Markdown
Contributor Author

I think so.
I'll put the migration notice in the next batch of release notes, then.

@TomaSajt TomaSajt marked this pull request as ready for review May 28, 2025 10:34
@github-actions github-actions bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label May 28, 2025
Copy link
Copy Markdown
Contributor

@niknetniko niknetniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge conflict This PR has merge conflicts with the target branch labels Jun 9, 2025
@pinpox
Copy link
Copy Markdown
Member

pinpox commented Jun 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391563
Commit: 61d536de981011c281a73499832db6b081f6d923


x86_64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
✅ 3 packages built:
  • gramps
  • gramps.dist
  • nixpkgs-manual

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 11, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 13, 2025
@github-actions github-actions bot removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jun 13, 2025
@wolfgangwalther
Copy link
Copy Markdown
Contributor

Re-running CI due to a odd failure fixed in #416448

@wrenix
Copy link
Copy Markdown
Contributor

wrenix commented Jun 14, 2025

Is there something missing? Could somebody else help?

Sorry for the pressure.

@natsukium natsukium merged commit dcf0290 into NixOS:master Jun 14, 2025
25 of 27 checks passed
@github-actions github-actions bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants