Conversation
06kellyjac
left a comment
There was a problem hiding this comment.
One comment but otherwise looks good.
I'll try run this with a PR with an existing project when I get a moment
06kellyjac
left a comment
There was a problem hiding this comment.
Import worked fine.
Should probably have a release note item though
I'm not sure what release note item you're talking about, could you clarify? |
|
From the PR template under "Things Done" above
Since this is a major version bump (5 -> 6) we should add a note in |
44a4a3b to
62e9177
Compare
|
Sorry for the long delay. In this specific case I don't think it's that necessary to mark the breaking changes in the release notes. |
|
Though, now that I looked into it, you can only make a backup in a version which still used the older schema version, so the backup should have been made before you upgraded your system. |
|
Edit: seems like the non release critical package feature freeze was on the 9th, and we missed that. |
|
Since the release is out of the door now, can we proceed with merging this? 🙂 |
|
I think so. |
|
|
Re-running CI due to a odd failure fixed in #416448 |
|
Is there something missing? Could somebody else help? Sorry for the pressure. |
https://github.com/gramps-project/gramps/releases
Added
orjsonpython package as a new dependency.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.