python313Packages.atopile: 0.2.69 -> 0.11.2#393261
python313Packages.atopile: 0.2.69 -> 0.11.2#393261SuperSandro2000 merged 22 commits intoNixOS:masterfrom
Conversation
c242d9b to
c5d3f43
Compare
c5d3f43 to
d1b7c07
Compare
|
|
d1b7c07 to
8d427e2
Compare
8d427e2 to
b7cc2e2
Compare
|
Please read https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#writing-good-commit-messages and update the commit messages. We set |
|
The PR has been opened for a bit more than a month, I couldn't know it would be still opened during the release breaking changes freeze 😅 I don't think it hurt anyone to let it be reviewed and merged at the appropriate time |
|
please split the package additions in 3841059 to separate commits |
6c80707 to
8d4f709
Compare
pkgs/development/python-modules/atopile-easyeda2ato/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/atopile-easyeda2ato/default.nix
Outdated
Show resolved
Hide resolved
094dc8d to
3c48c23
Compare
230d2dd to
0c5bd5a
Compare
0c5bd5a to
95c4a56
Compare
protoletariat
95c4a56 to
d148324
Compare
|
@SuperSandro2000 Done! |
SuperSandro2000
left a comment
There was a problem hiding this comment.
running a nixpkgs-review just to make sure and then going to merge this finally 🎉
|
d148324 to
78bc803
Compare
|
Figured out that |
78bc803 to
c24ee54
Compare
|
atopile/atopile@v0.10.15...v0.10.23 python313Packages.atopile: remove posthog patch
c24ee54 to
c722937
Compare
c722937 to
93364bd
Compare
|
| pynng | ||
| mypy-protobuf | ||
| ] | ||
| ++ (lib.optional (pythonOlder "3.13") typing-extensions); |
There was a problem hiding this comment.
| ++ (lib.optional (pythonOlder "3.13") typing-extensions); | |
| ++ lib.optional (pythonOlder "3.13") typing-extensions; |
| # using pytestFlags causes `ERROR: file or directory not found: slow` | ||
| pytestFlagsArray = [ | ||
| "-m='not slow and not not_in_ci and not regression'" | ||
| "--timeout=10" # any test taking long, timouts with more than 60s |
There was a problem hiding this comment.
Why did the comment say "timouts with more than 60s" but the flag say --timeout=10?
When working on PR #452102, nixpkgs-review tests run with nixpkgs-review-gha fails to build python313Packages.atopile on x86_64-linux due to test timeout (#452102 (comment)). The following is part of the build log:
........................................................................ [ 93%]
.................................error uploading: HTTPSConnectionPool(host='telemetry.atopileapi.com', port=443): Max retries exceeded with url: /batch/ (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x7fffbeb1b4d0>: Failed to resolve 'telemetry.atopileapi.com' ([Errno -3] Temporary failure in name resolution)"))
error uploading: HTTPSConnectionPool(host='telemetry.atopileapi.com', port=443): Max retries exceeded with url: /batch/ (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x7fffbe647c50>: Failed to resolve 'telemetry.atopileapi.com' ([Errno -3] Temporary failure in name resolution)"))
error uploading: HTTPSConnectionPool(host='telemetry.atopileapi.com', port=443): Max retries exceeded with url: /batch/ (Caused by NameResolutionError("<urllib3.connection.HTTPSConnection object at 0x7fffbe9c0050>: Failed to resolve 'telemetry.atopileapi.com' ([Errno -3] Temporary failure in name resolution)"))
....................................... [ 98%]
....................xxx.. [100%]
=================================== FAILURES ===================================
/nix/store/lcp5h087xp01smj5xjwddpnddq1lsw4d-python3.13-atopile-0.12.4/lib/python3.13/site-packages/faebryk/core/pathfinder.py:41: Failed: Timeout (>10.0s) from pytest-timeout.
=========================== short test summary info ============================
FAILED test/core/test_mif_connect.py::test_regression_rp2040_usb_diffpair - Failed: Timeout (>10.0s) from pytest-timeout.
====== 1 failed, 1345 passed, 26 skipped, 21 xfailed in 79.45s (0:01:19) =======
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.