Skip to content

haskell.packages.ghc912.{feed,xml-conduit}: fix#406003

Merged
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:ghc912fixes
May 16, 2025
Merged

haskell.packages.ghc912.{feed,xml-conduit}: fix#406003
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:ghc912fixes

Conversation

@sternenseemann
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 10, 2025
@sternenseemann sternenseemann requested a review from alexfmpe May 10, 2025 23:04
@nix-owners nix-owners bot requested review from maralorn and wolfgangwalther May 10, 2025 23:06
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 10, 2025
@maralorn
Copy link
Member

Thank you!

Is this affecting a hydra job we have?

@sternenseemann

This comment was marked as outdated.

@sternenseemann
Copy link
Member Author

xml-conduit has a reverse dependency closure of 3759, so that's probably why. Maybe better to wait on the next rotation for this or merge into staging…

@maralorn
Copy link
Member

Ah, no. I was more curious about why you are fixing a 9.12 build. I also noticed that xml-conduit is broken because I am playing with reflex-dom on 9.12 and the lack of any hydra jobs to actually determine if they are working is slightly annoying.

@maralorn
Copy link
Member

I am fine with merging anywhere.

@sternenseemann sternenseemann merged commit 272b8f9 into NixOS:haskell-updates May 16, 2025
23 checks passed
@sternenseemann sternenseemann deleted the ghc912fixes branch May 16, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants