Skip to content

octavePackages.mapping: 1.4.2 -> 1.4.3#406300

Merged
pbsds merged 2 commits intoNixOS:masterfrom
KarlJoad:octavePackages/mapping
May 28, 2025
Merged

octavePackages.mapping: 1.4.2 -> 1.4.3#406300
pbsds merged 2 commits intoNixOS:masterfrom
KarlJoad:octavePackages/mapping

Conversation

@KarlJoad
Copy link
Contributor

Use r-ryantm's auto-update and fix runtime dependency on gdal. Adding this runtime dependency makes all unit tests pass.

Extension of #405785.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 12, 2025
@pbsds
Copy link
Member

pbsds commented May 28, 2025

I'm not familiar with octave, but this package seems to only be a zip with some propagations

$ fd --no-ignore --hidden -L . result*/ --type f
results/octavePackages.mapping-x86_64-linux/mapping-1.4.3-x86_64-pc-linux-gnu-api-v60.tar.gz
results/octavePackages.mapping-x86_64-linux/nix-support/propagated-build-inputs
results/octavePackages.mapping-x86_64-linux/nix-support/required-octave-packages

Is this expected?

@pbsbot
Copy link

pbsbot commented May 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406300


x86_64-linux

✅ 1 package built:
  • octavePackages.mapping

@KarlJoad
Copy link
Contributor Author

@pbsds, yes this output is expected. Octave is a weird packaging environment. Every octave package's output (rather any Octave package produced by buildOctavePackage) is a tarball. Building a single octavePackage.* is useless (unless you want the compiled output).

Instead, you must couple your package selection with an octave package using the withPackages function. If you do that, then each package's output tarball is then fed into an octave environment where the tarball is unpacked and the requested Octave has the packages installed.

nix-shell -p 'octave.withPackages (os: with os; [ mapping ])'

will install octavePackages.mapping into the correct spot in the environment, make octave aware of it, and make the octave command available for use.

See the nixpkgs documentation for more explanation.
https://nixos.org/manual/nixpkgs/stable/#ssec-octave-packaging

@pbsds
Copy link
Member

pbsds commented May 28, 2025

I took a crack at fixing that here

@pbsds
Copy link
Member

pbsds commented May 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 406300


x86_64-linux

✅ 1 package built:
  • octavePackages.mapping

aarch64-linux

✅ 1 package built:
  • octavePackages.mapping

x86_64-darwin

❌ 1 package failed to build:
  • octavePackages.mapping

aarch64-darwin

❌ 1 package failed to build:
  • octavePackages.mapping

darwin failures are due to the input octavePackages.geometry failing on darwin, not a regression

@pbsds pbsds merged commit 6ed432a into NixOS:master May 28, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants