Skip to content

nufmt: 0-unstable-2025-04-28 -> 0-unstable-2025-05-23 #408552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
khaneliman merged 1 commit into from
Jun 20, 2025
Merged

nufmt: 0-unstable-2025-04-28 -> 0-unstable-2025-05-23 #408552

khaneliman merged 1 commit into from
Jun 20, 2025

Conversation

@khaneliman
Copy link
Contributor

@khaneliman khaneliman commented May 18, 2025 •
edited
Loading

Things done

Needed a patch due to some test changes. Created nushell/nufmt#71 upstream, as well..

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels May 18, 2025
@nix-owners nix-owners bot requested a review from IogaMaster May 18, 2025 23:43
@khaneliman khaneliman marked this pull request as draft May 20, 2025 02:40
@khaneliman khaneliman changed the title nufmt: 0-unstable-2025-04-28 -> 0-unstable-2025-05-08 nufmt: 0-unstable-2025-04-28 -> 0-unstable-2025-05-23 Jun 19, 2025
@khaneliman khaneliman marked this pull request as ready for review June 19, 2025 05:10
@khaneliman
Copy link
Contributor Author

khaneliman commented Jun 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 408552
Commit: 82d5578552c89e2b0c1f52ece59502507866bcaa

x86_64-linux

✅ 1 package built:
  • nufmt

aarch64-linux

✅ 1 package built:
  • nufmt

x86_64-darwin

✅ 1 package built:
  • nufmt

aarch64-darwin

✅ 1 package built:
  • nufmt

@khaneliman khaneliman merged commit 49b4c51 into NixOS:master Jun 20, 2025
28 of 31 checks passed
@khaneliman khaneliman deleted the updates branch June 22, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IogaMaster IogaMaster Awaiting requested review from IogaMaster

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@khaneliman