Closed
Conversation
Correct type signatures
github-actions
bot
added
the
6.topic: R
aitap
reviewed
Jun 24, 2025
Comment on lines
+10
to
+20
| +void slUniqify(void *pList, int (*compare )(const void *elem1, const void *elem2), void (*freeFunc)()) | ||
| /* Return sorted list with duplicates removed. | ||
| * Compare should be same type of function as slSort's compare (taking | ||
| * pointers to pointers to elements. Free should take a simple | ||
| @@ -356,7 +356,7 @@ while ((el = slPopHead(&oldList)) != NULL) | ||
| { | ||
| if ((newList == NULL) || (compare(&newList, &el) != 0)) | ||
| slAddHead(&newList, el); | ||
| - else if (free != NULL) | ||
| + else if (freeFunc != NULL) | ||
| free(el); |
There was a problem hiding this comment.
Since the comment says
Free should take a simple pointer to dispose of duplicate element
...this should be void (*freeFunc)(void *) and freeFunc(el).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct type signatures
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.