Skip to content

[25.05] haskellPackages.selda-sqlite: unbreak#412515

Merged
wolfgangwalther merged 3 commits intoNixOS:release-25.05from
rnhmjoj:pr-selda-back
Jun 1, 2025
Merged

[25.05] haskellPackages.selda-sqlite: unbreak#412515
wolfgangwalther merged 3 commits intoNixOS:release-25.05from
rnhmjoj:pr-selda-back

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented May 30, 2025

Backport of #405820 to 25.05

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 4.workflow: backport This targets a stable branch labels May 30, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 30, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented May 31, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 412515

x86_64-linux

❌ 2 packages failed to build:
  • haskellPackages.selda-json
  • haskellPackages.selda-json.doc
✅ 4 packages built:
  • haskellPackages.selda
  • haskellPackages.selda-sqlite
  • haskellPackages.selda-sqlite.doc
  • haskellPackages.selda.doc

aarch64-linux

❌ 2 packages failed to build:
  • haskellPackages.selda-json
  • haskellPackages.selda-json.doc
✅ 4 packages built:
  • haskellPackages.selda
  • haskellPackages.selda-sqlite
  • haskellPackages.selda-sqlite.doc
  • haskellPackages.selda.doc

x86_64-darwin

❌ 2 packages failed to build:
  • haskellPackages.selda-json
  • haskellPackages.selda-json.doc
✅ 4 packages built:
  • haskellPackages.selda
  • haskellPackages.selda-sqlite
  • haskellPackages.selda-sqlite.doc
  • haskellPackages.selda.doc

aarch64-darwin

❌ 2 packages failed to build:
  • haskellPackages.selda-json
  • haskellPackages.selda-json.doc
✅ 4 packages built:
  • haskellPackages.selda
  • haskellPackages.selda-sqlite
  • haskellPackages.selda-sqlite.doc
  • haskellPackages.selda.doc

selda-json builds fine on master. It fails with:

       > Error: Setup: Encountered missing or private dependencies:
       > aeson >=1.0 && <2.2

Might wanna fix that as well while at it (or not, fine, too).

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented May 31, 2025

Might wanna fix that as well while at it (or not, fine, too).

Yes, but this is a backport.

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented May 31, 2025

Well, if you want to have selda-json working on release-25.05, you can't do that via backport - because it already works on master. So the only place to fix it, if you need it, is here, or in a different PR targeting stable directly.

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented May 31, 2025 •
edited
Loading

Actually... this seems like a regression. selda-json builds fine on release-25.05 right now. I'm confused why, because I assumed it to be broken because selda-sqlite is broken. But that's not the case.

Edit: Ah, it's a direct rebuild, not transitive via selda-sqlite. So yeah, this commit currently breaks selda-json.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented May 31, 2025

Actually... this seems like a regression. selda-json builds fine on release-25.05 right now. I'm confused why, because I assumed it to be broken because selda-sqlite is broken. But that's not the case.

Ah, I see. I've backported the fix from haskell-updates where selda-json is broken and I didn't even know it was ok in release-25.05.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 31, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jun 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 412515
Commit: a98936ab27a547bd78007ba6c7024740374c72e3

x86_64-linux

✅ 2 packages built:
  • haskellPackages.selda-sqlite
  • haskellPackages.selda-sqlite.doc

aarch64-linux

✅ 2 packages built:
  • haskellPackages.selda-sqlite
  • haskellPackages.selda-sqlite.doc

x86_64-darwin

✅ 2 packages built:
  • haskellPackages.selda-sqlite
  • haskellPackages.selda-sqlite.doc

aarch64-darwin

✅ 2 packages built:
  • haskellPackages.selda-sqlite
  • haskellPackages.selda-sqlite.doc

@wolfgangwalther wolfgangwalther merged commit dc6b3e4 into NixOS:release-25.05 Jun 1, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

4.workflow: backport This targets a stable branch 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rnhmjoj @wolfgangwalther @sternenseemann