Skip to content

owi: init at 0.2-unstable-2025-05-05#414133

Merged
vbgl merged 1 commit intoNixOS:masterfrom
ethancedwards8:owi
Jul 4, 2025
Merged

owi: init at 0.2-unstable-2025-05-05#414133
vbgl merged 1 commit intoNixOS:masterfrom
ethancedwards8:owi

Conversation

@ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Jun 5, 2025

Things done

Having trouble getting tests to pass. I may split the Ocaml libraries into a separate PR just to have them merged earlier.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Jun 5, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 5, 2025
@ethancedwards8 ethancedwards8 mentioned this pull request Jun 5, 2025
13 tasks
@ethancedwards8 ethancedwards8 changed the title [WIP] owi: init at 0.2 owi: init at 0.2 Jun 6, 2025
@ethancedwards8 ethancedwards8 marked this pull request as ready for review June 6, 2025 20:06
@nix-owners nix-owners bot requested a review from ulrikstrid June 6, 2025 20:08
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 6, 2025
@ethancedwards8 ethancedwards8 force-pushed the owi branch 4 times, most recently from 59cf0e9 to 162c73e Compare June 8, 2025 16:24
@github-actions github-actions bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 8, 2025
@ethancedwards8 ethancedwards8 force-pushed the owi branch 2 times, most recently from c97f74d to a705cfc Compare June 8, 2025 17:00
@ethancedwards8 ethancedwards8 force-pushed the owi branch 5 times, most recently from 36cd2ae to 46fa532 Compare June 11, 2025 04:19
@vbgl
Copy link
Contributor

vbgl commented Jun 13, 2025

Can you please elaborate what is the issue with the current state (before this PR) of the ocamlPackages.z3 library? Your comment does not match my own observations.

@ethancedwards8
Copy link
Member Author

Can you please elaborate what is the issue with the current state (before this PR) of the ocamlPackages.z3 library? Your comment does not match my own observations.

SMTML would not correctly compile/detect the z3 library in the old way of packaging it.

@ethancedwards8 ethancedwards8 force-pushed the owi branch 2 times, most recently from 3a3f5a1 to db1ebf9 Compare June 15, 2025 18:19
@vbgl
Copy link
Contributor

vbgl commented Jun 16, 2025

I could indeed reproduce the issue with z3. I propose an other (much simpler) fix there: #417157 What do you think?

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 18, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 18, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 18, 2025
@ethancedwards8 ethancedwards8 force-pushed the owi branch 2 times, most recently from fffaa78 to 6a095b5 Compare June 20, 2025 20:35
NLNet project: https://nlnet.nl/project/OWI/

Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
@ethancedwards8
Copy link
Member Author

This is still a WIP. I will report back here when ready for review.

@ethancedwards8 ethancedwards8 marked this pull request as draft June 26, 2025 17:46
@ethancedwards8 ethancedwards8 marked this pull request as draft June 26, 2025 17:46
@nixpkgs-ci nixpkgs-ci bot removed the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Jun 26, 2025
@ethancedwards8
Copy link
Member Author

@vbgl these tests won't pass until I have packaged a library called frama-c. It is fairly involved and does not build using buildDunePackage. Is it worth packaging just for the tests? As far as I can tell, the package works in its current state.

@vbgl
Copy link
Contributor

vbgl commented Jul 2, 2025

Frama-C has been in nixpkgs for ages, under the attribute framac. But it is probably fine not to enable tests for this derivation.

@ethancedwards8
Copy link
Member Author

Yeah, the program. I need the library. Just adding the program only didn't work.

@ethancedwards8 ethancedwards8 marked this pull request as ready for review July 4, 2025 05:42
@ethancedwards8
Copy link
Member Author

Anyways, if you think this is ready to go without the tests, I'll mark it as ready to review.

@vbgl vbgl merged commit fa30164 into NixOS:master Jul 4, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants