Skip to content

python3Packages.cddlparser: init at 0.5.0#414527

Merged
matthiasbeyer merged 2 commits intoNixOS:masterfrom
TheNeikos:init/cddlparser
Jun 12, 2025
Merged

python3Packages.cddlparser: init at 0.5.0#414527
matthiasbeyer merged 2 commits intoNixOS:masterfrom
TheNeikos:init/cddlparser

Conversation

@TheNeikos
Copy link
Copy Markdown
Contributor

@TheNeikos TheNeikos commented Jun 6, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 6, 2025
@nix-owners nix-owners bot requested a review from natsukium June 6, 2025 14:04
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 6, 2025
Sigmanificient
Sigmanificient previously requested changes Jun 8, 2025
View reviewed changes
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 8, 2025
TheNeikos added 2 commits June 8, 2025 17:52
@TheNeikos
maintainers: add hemera
a92970f 
Signed-off-by: Marcel Müller <neikos@neikos.email>
@TheNeikos
python3Packages.cddlparser: init at 0.5.0
d5c08a2 
Signed-off-by: Marcel Müller <neikos@neikos.email>
@TheNeikos TheNeikos requested a review from Sigmanificient June 8, 2025 15:53
@TheNeikos
Copy link
Copy Markdown
Contributor Author

TheNeikos commented Jun 8, 2025 •
edited
Loading

@Sigmanificient thanks for the review!

I've addressed the comments :D

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 11, 2025
@matthiasbeyer
Copy link
Copy Markdown
Contributor

matthiasbeyer commented Jun 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 414527
Commit: d5c08a2e53ffb2cec243268ed46678febae47306

x86_64-linux

✅ 4 packages built:
  • python312Packages.cddlparser
  • python312Packages.cddlparser.dist
  • python313Packages.cddlparser
  • python313Packages.cddlparser.dist

@matthiasbeyer matthiasbeyer dismissed Sigmanificient’s stale review June 12, 2025 07:35

Issues were addressed

@matthiasbeyer matthiasbeyer merged commit 12f126e into NixOS:master Jun 12, 2025
18 of 19 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jul 4, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jul 4, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 4, 2025
@TheNeikos TheNeikos deleted the init/cddlparser branch July 4, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@Sigmanificient Sigmanificient Awaiting requested review from Sigmanificient

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TheNeikos @matthiasbeyer @Sigmanificient @mdaniels5757 @wegank