pngpaste: refactor package.nix and hardcode repo.#414766
Merged
pbsds merged 1 commit intoNixOS:masterfrom Jun 11, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 1-10
guylamar2006
force-pushed
the
refactor-pngpaste
branch
2 times, most recently
from
1dbbaf2 to
84cd904
Compare
github-actions
bot
added
10.rebuild-darwin: 0
guylamar2006
force-pushed
the
refactor-pngpaste
branch
2 times, most recently
from
b9d892b to
8e05c14
Compare
github-actions
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
wlcx
suggested changes
Jun 7, 2025
Contributor
wlcx
left a comment
wlcx
left a comment
There was a problem hiding this comment.
Thanks, looks good other than a very minor suggestion while we're here
guylamar2006
force-pushed
the
refactor-pngpaste
branch
2 times, most recently
from
816ba90 to
eea6237
Compare
Contributor
|
LGTM! Probably worth squashing into one commit. Happy to merge after. |
pngpaste: switch to finalAttrs pngpaste: simplify installPhase logic Co-authored-by: Sam W <sam@wlcx.cc>
guylamar2006
force-pushed
the
refactor-pngpaste
branch
from
eea6237 to
34a118f
Compare
Contributor
|
@NixOS/nixpkgs-merge-bot merge |
Contributor
wlcx
approved these changes
Jun 8, 2025
Contributor
|
Guess that only works with bot generated MRs then 🤷 |
wegank
added
12.approved-by: package-maintainer
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor package.nix and hardcode repo from pname and change rev -> tag, and apply nixpkgs-hammering fixes.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.