nixos/borgbackup: add extraArgs to wrapper script#415272
Merged
Scrumplex merged 1 commit intoNixOS:masterfrom Feb 21, 2026
Merged
nixos/borgbackup: add extraArgs to wrapper script#415272Scrumplex merged 1 commit intoNixOS:masterfrom
Scrumplex merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
nixpkgs-ci
bot
added
the
9.needs: reviewer
nixpkgs-ci
bot
added
the
2.status: merge conflict
DoctorDalek1963
force-pushed
the
borg-wrapper-script-extra-args
branch
from
7e11e7b to
d8a5937
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: merge conflict
DoctorDalek1963
force-pushed
the
borg-wrapper-script-extra-args
branch
from
d8a5937 to
cb44226
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
Member
|
@DoctorDalek1963 Automatic assigning of maintainers does not work for modules, please ping the maintainers (as given in the module) explicitly. I've done so for you now. |
nixpkgs-ci
bot
removed
the
9.needs: reviewer
Scrumplex
reviewed
Jan 12, 2026
Member
Scrumplex
left a comment
Scrumplex
left a comment
There was a problem hiding this comment.
LGTM. Could you mention this in extraArgs' description. This is a significant difference from the other extra*Args options
DoctorDalek1963
force-pushed
the
borg-wrapper-script-extra-args
branch
from
cb44226 to
f1fbeb1
Compare
Scrumplex
approved these changes
Feb 21, 2026
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
force-pushed
the
borg-wrapper-script-extra-args
branch
from
f1fbeb1 to
719d621
Compare
Member
|
I have adjusted one of NixOS tests to make use of this new behavior. I'll merge this one checks pass. |
nixpkgs-ci
bot
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the
extraArgsin the generated wrapper script for each borgbackup job. Some remotes require a specific version of borg to be passed with--remote-pathor they just won't work. This can create a very confusing situation where the systemd service can connect and make backups, but the wrapper script says that borg isn't running on the server.This PR means that
--remote-pathand other common flags like--verbosewill be included in the wrapper script.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.