Merged
Conversation
Member
|
Contributor
Author
|
I see that the formatter check isn't happy with what I've done with the flags, but I'd like to keep it as-is if possible since the readability this way is so much better. |
Member
|
I would apply the patch. There is not a way to preserve your manual formatting long term, it will eventually be reformatted by someone else. |
08bb0cc to
ca646c4
Compare
Contributor
Author
|
All right, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the Cling build (and general functionality) was broken on macOS. This is because on macOS, we use
libc++rather thanglibc. The latter is self-contained, so it works on Linux without additional includes. But on macOS, we need to add the system includes from theapple-sdkpackage so it can find files likestdlib.h.I also inlined some flags and changed the formatting to make it easier to see what's going on. Linux should be unaffected by this change.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.