nixos/authelia: add options for SMTP secrets#416242
Open
stackptr wants to merge 3 commits intoNixOS:masterfrom
Open
nixos/authelia: add options for SMTP secrets#416242stackptr wants to merge 3 commits intoNixOS:masterfrom
stackptr wants to merge 3 commits intoNixOS:masterfrom
Conversation
This environment variable is referenced here: https://www.authelia.com/configuration/methods/secrets/
This environment variable is referenced here: https://www.authelia.com/configuration/methods/secrets/
This environment variable is referenced here: https://www.authelia.com/configuration/methods/secrets/
6705df7 to
836ee82
Compare
Ma27
reviewed
Jun 13, 2025
| }; | ||
|
|
||
| notifierSmtpPasswordFile = mkOption { | ||
| type = types.nullOr types.path; |
Member
There was a problem hiding this comment.
types.path is usually not what you want: this accepts path literals and when somebody uses them wrongly (i.e. "${toString pathLiteral}" vs "${pathLiteral}") you end up silently copying things into your store.
pathWith is what you'll probably want.
Contributor
Author
There was a problem hiding this comment.
Good to know! The existing options use types.path as well -- do you think it's appropriate for this PR to address those options, too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following options for configuring Authelia to notify via SMTP:
services.authelia.instances.<name>.secrets.notifierSmtpPasswordFileservices.authelia.instances.<name>.secrets.notifierSmtpTlsCertificateChainFileservices.authelia.instances.<name>.secrets.notifierSmtpTlsPrivateKeyFileThese correspond to environment variables documented here: https://www.authelia.com/configuration/methods/secrets/
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.