pjsip: fix builds failing to patch executables on macos#416258
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Jun 16, 2025
Merged
pjsip: fix builds failing to patch executables on macos#416258Aleksanaa merged 1 commit intoNixOS:masterfrom
Aleksanaa merged 1 commit intoNixOS:masterfrom
Conversation
A lot of non-executable files in the build output are marked as executable, including a header file, which causes `install_name_tool` to fail. We now search `/bin` and `/share/**/samples` specifically and check that the file is a Mach-O binary before patching.
github-actions
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of non-executable files in the build output are marked as executable, including a header file, which causes
install_name_toolto fail.We now search
/binand/share/**/samplesspecifically and check that the file is a Mach-O binary before patching.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.