scx.full: 1.0.12 -> 1.0.13#416262
Merged
JohnRTitor merged 4 commits intoNixOS:masterfrom Jun 13, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
Member
Author
|
JohnRTitor
reviewed
Jun 13, 2025
JohnRTitor
reviewed
Jun 13, 2025
Member
JohnRTitor
left a comment
JohnRTitor
left a comment
There was a problem hiding this comment.
Could you amend the commits such that:
- First one is only a version bump commit, with the required changes for it to build
- Second one is enabling/skipping tests
- This one is fine
Note that you should use the actual attribute like: scx.full scx.cscheds scx.rustscheds for Ofborg to pick it up for building.
JohnRTitor
reviewed
Jun 13, 2025
Member
|
Signed-off-by: John Titor <50095635+JohnRTitor@users.noreply.github.com>
Member
|
I think I am getting some weird behaviour with 1st run: Details2nd run: DetailsLooks like nixos tests are still passing, ie, not being affected. |
Member
|
CC @JakeHillion an upstream dev. And I noticed something else too, unrelated to the above issue. I am seeing BPF skeleton version is old warning, even though we are fetching the same libbpf commit as upstream wants (as you can see in version.json) and building it with upstream's script. |
Member
Author
|
I'm getting the same output as you with |
JohnRTitor
approved these changes
Jun 13, 2025
Member
There was a problem hiding this comment.
Let's wait a bit for Jake's reply.
But I am leaning towards merging this. Doesn't look like people use scx_central at all on NixOS as far as I can see with a simple GitHub search.
https://github.com/search?q=scx_central+path%3A*.nix&type=code
Member
yeah I just tried it as well. Weirdly enough, I remember this working fine when I tested the PR for 1.0.12. Perhaps something changed in the kernel implementation of |
Contributor
Hey, thanks for the tag. I've been seeing this for a while on my dev machine too and haven't gotten to the bottom of it. I don't think it's a big deal other than being annoying, but will check with the other maintainers and get back to you. RE scx_central, the cscheds generally have weaker maintenance than the rust scheds, but we can take a look. Could we get your |
Member
Logs from 1.0.12. Detailsuname output. |
github-actions
bot
added
the
12.approvals: 1
Member
|
This should be backported to 25.05 as kernel releases are also backported.
*Masum Reza*
|
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/sched-ext/scx/releases/tag/v1.0.13
llvmPackages.libllvmto cscheds'buildInputsbecausellvm-stripis now requireddoCheckforscx_cschedsscx_rustscheds' tests fails ifdoCheckis enabled, so I kept it disabled for now.Here's the failing tests result:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.