Skip to content

xnconvert: init at v1.105.0#416273

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
aldenparker:add-xnconvert
Jun 13, 2025
Merged

xnconvert: init at v1.105.0#416273
Sigmanificient merged 2 commits intoNixOS:masterfrom
aldenparker:add-xnconvert

Conversation

@aldenparker
Copy link
Copy Markdown
Contributor

Added package for xnconvert.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 12, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 12, 2025
@aldenparker
Copy link
Copy Markdown
Contributor Author

This is my first contribution, so if there is anything wrong procedure wise, please tell me as I have a few more packages I would like to push and want to do them right the first time.
Also, I only have a x86_64-linux device with GUI loaded on it, so if anyone wants to build and test the app on other architectures, be my guest and feel free to update the platforms section. This should work on all linux architectures.

@aldenparker
Copy link
Copy Markdown
Contributor Author

Ok I swapped to the app image version so that it for sure works on all linux archs

Copy link
Copy Markdown
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, let me guide you through your first pr into nixpkgs!

The repository follow a commit convention, so you'll need to change the history in order to have the 2 following commits:

maintainers: add aldenparker
xnconvert: init at 1.105.0

Because this constitute 2 different actions (adding yourself in the maintainer list then adding a package)!

I have added a few suggestion below, you can ask me any question!

@aldenparker
Copy link
Copy Markdown
Contributor Author

aldenparker commented Jun 12, 2025

Thank you for the help. I am about to apply the suggestions, is there any specific commit message style for doing so?

Edit: looking at the commit conventions, it seems I just need the package name in front. So my next question would be should I squash it into the init commit or leave with extra message.

@Sigmanificient
Copy link
Copy Markdown
Member

Yup, squash it down the the 2 commits i mentioned!

@aldenparker
Copy link
Copy Markdown
Contributor Author

Thanks for the help! This should do it.

@Sigmanificient
Copy link
Copy Markdown
Member

pkgs/by-name/xn/xnconvert/package.nix is present on the first commit 👀
Sorry for bothering you on that (Can you also reomve the trailing . in the description)?

@aldenparker
Copy link
Copy Markdown
Contributor Author

Alright there we go. Sorry about that.

@aldenparker
Copy link
Copy Markdown
Contributor Author

Lastly, I would like to backport this for 25.05. The docs say I can add a label, but I can't seem to do that. Could you add this label or tell me how to? If I remember right it has to do with repo permissions, so I probably can't do it myself.

@Sigmanificient
Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 416273

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/15623439971


x86_64-linux

✅ 1 package built:
  • xnconvert

aarch64-linux

✅ 1 package built:
  • xnconvert

@Sigmanificient Sigmanificient merged commit da06215 into NixOS:master Jun 13, 2025
15 of 19 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jun 13, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 13, 2025
@aldenparker aldenparker deleted the add-xnconvert branch June 13, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants