xnconvert: init at v1.105.0#416273
Conversation
|
This is my first contribution, so if there is anything wrong procedure wise, please tell me as I have a few more packages I would like to push and want to do them right the first time. |
|
Ok I swapped to the app image version so that it for sure works on all linux archs |
Sigmanificient
left a comment
There was a problem hiding this comment.
Hi, let me guide you through your first pr into nixpkgs!
The repository follow a commit convention, so you'll need to change the history in order to have the 2 following commits:
maintainers: add aldenparker
xnconvert: init at 1.105.0
Because this constitute 2 different actions (adding yourself in the maintainer list then adding a package)!
I have added a few suggestion below, you can ask me any question!
7f3706b to
1ba44ed
Compare
|
Thank you for the help. I am about to apply the suggestions, is there any specific commit message style for doing so? Edit: looking at the commit conventions, it seems I just need the package name in front. So my next question would be should I squash it into the init commit or leave with extra message. |
|
Yup, squash it down the the 2 commits i mentioned! |
1ba44ed to
c8d4444
Compare
|
Thanks for the help! This should do it. |
|
|
c8d4444 to
ecc4bf8
Compare
|
Alright there we go. Sorry about that. |
|
Lastly, I would like to backport this for 25.05. The docs say I can add a label, but I can't seem to do that. Could you add this label or tell me how to? If I remember right it has to do with repo permissions, so I probably can't do it myself. |
|
|
Successfully created backport PR for |
Added package for xnconvert.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.