varnish: fix builds of varnish, varnish77, and varnish60 on macOS#416291
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Jun 17, 2025
Merged
varnish: fix builds of varnish, varnish77, and varnish60 on macOS#416291Aleksanaa merged 1 commit intoNixOS:masterfrom
varnish, varnish77, and varnish60 on macOS#416291Aleksanaa merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 1-10
nix-owners
bot
requested review from
Ma27,
ctheune,
dpausp,
frlan,
leona-ya and
osnyx
Contributor
Author
|
Aleksanaa
reviewed
Jun 16, 2025
Applies several patches to get varnish to build on macOS.
For `varnish77`:
- Fix `endian.h` compatibility for macOS
varnishcache/varnish-cache#4339
- Fix VMOD section attribute on macOS
https://github.com/varnishcache/varnish-cache/commit/a95399f5b9eda1bfdba6ee6406c30a1ed0720167.patch
For `varnish60`:
- Fix duplicate OS_CODE definitions on macOS
varnishcache/varnish-cache#4347
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies several patches to get varnish to build on macOS.
For
varnish77:Fix
endian.hcompatibility for macOSbuild: macos compatibility build fixes varnishcache/varnish-cache#4339
Fix VMOD section attribute on macOS
https://github.com/varnishcache/varnish-cache/commit/a95399f5b9eda1bfdba6ee6406c30a1ed0720167.patch
For
varnish60:build: fix duplicate OS_CODE definitions on macOS varnishcache/varnish-cache#4347
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.