workflows/build: build all the basics in a single workflow#416368
Merged
Mic92 merged 2 commits intoNixOS:masterfrom Jun 13, 2025
Merged
workflows/build: build all the basics in a single workflow#416368Mic92 merged 2 commits intoNixOS:masterfrom
Mic92 merged 2 commits intoNixOS:masterfrom
Conversation
To enable *required status checks / workflows* in the future, we'd like to run all workflows unconditionally. Since those workflows are already using cachix, the additional runs will be very cheap. Yes, we'll run additional jobs, but that will be temporary only, see next commits. The immediate upside is, that we're not going to accidentally miss some of the paths that would cause rebuilds as we did in the past.
This new workflow builds both manuals, the shell and the lib tests all in a matrix of four jobs. This allows re-using the shared checkout and the pinned nixpkgs download and saves time in the most likely cache: No changes, just download from cache. Each step checks the cancelled condition, which causes it to run even if the previous steps failed. This way we get a full picture even if the first step fails immediately. This could later be optimized to build more in parallel as well, but we'll first need to clear the conditions on building the manuals on the master branch only. This reduces the number of jobs from up to 8 to 4 for this part.
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
philiptaron,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-416368-to-release-24.11 origin/release-24.11
cd .worktree/backport-416368-to-release-24.11
git switch --create backport-416368-to-release-24.11
git cherry-pick -x 540fd4e30f7d3de2ee908febff560af23bd800ca cd82aa54f525559f157360c3432d923bae3798a8 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-416368-to-release-25.05 origin/release-25.05
cd .worktree/backport-416368-to-release-25.05
git switch --create backport-416368-to-release-25.05
git cherry-pick -x 540fd4e30f7d3de2ee908febff560af23bd800ca cd82aa54f525559f157360c3432d923bae3798a8 |
Contributor
|
Successfully created backport PR for |
1 task
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new workflow builds both manuals, the shell and the lib tests all in a matrix of four jobs. This allows re-using the shared checkout and the pinned nixpkgs download and saves time in the most likely cache: No changes, just download from cache. Each step checks the cancelled condition, which causes it to run even if the previous steps failed. This way we get a full picture even if the first step fails immediately.
This could later be optimized to build more in parallel as well, but we'll first need to clear the conditions on building the manuals on the master branch only. (#416241)
Split off from #415006 to make review and merge in steps possible. See that PR for more rationale.
Things done
Add a 👍 reaction to pull requests you find important.