Skip to content

workflows/check: run "checks" in one workflow#416369

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-check
Jun 13, 2025
Merged

workflows/check: run "checks" in one workflow#416369
Mic92 merged 1 commit intoNixOS:masterfrom
wolfgangwalther:ci-check

Conversation

@wolfgangwalther
Copy link
Copy Markdown
Contributor

This introduces "check" as another category of jobs suitable for the "Require status checks to pass" feature.

Checks as a category would include everything that is done before even looking at the code: Right branch? Commit messages? Cherry-picked correctly?

(commit messages are not checked, yet)

Split off from #415006 to make review and merge in steps possible. See that PR for rationale.

Things done


Add a 👍 reaction to pull requests you find important.

This introduces "check" as another category of jobs suitable for the
"Require status checks to pass" feature.

Checks as a category would include everything that is done before even
looking at the code: Right branch? Commit messages? Cherry-picked
correctly?

(commit messages are not checked, yet)
@github-actions github-actions bot added 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs backport release-24.11 labels Jun 13, 2025
@wolfgangwalther wolfgangwalther mentioned this pull request Jun 13, 2025
3 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 13, 2025
@Mic92 Mic92 merged commit dbcae2b into NixOS:master Jun 13, 2025
15 of 18 checks passed
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jun 13, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-416369-to-release-24.11 origin/release-24.11
cd .worktree/backport-416369-to-release-24.11
git switch --create backport-416369-to-release-24.11
git cherry-pick -x f11b58a7a099b701c3d929ea2cded036a0a5dafd

@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jun 13, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-416369-to-release-25.05 origin/release-25.05
cd .worktree/backport-416369-to-release-25.05
git switch --create backport-416369-to-release-25.05
git cherry-pick -x f11b58a7a099b701c3d929ea2cded036a0a5dafd

@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jun 13, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Jun 13, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 13, 2025
@wolfgangwalther wolfgangwalther deleted the ci-check branch June 13, 2025 11:22
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Jun 20, 2025

FYI, the check seems to misunderstand the staging-next-25.05 workflow. It complains about perfectly clean merges that merged correct (even automatic) cherry-picks into staging-25.05. It even complains about

Merge remote-tracking branch 'origin/master' into staging-next-25.05

See basically any complaint in #418358 (review)

@wolfgangwalther
Copy link
Copy Markdown
Contributor Author

Thanks for the report, will look into this. I'd say it doesn't make sense to run the check cherry-picks workflow on the staging PRs at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants