Skip to content

python312Packages.vllm: 0.9.0.1 -> 0.9.1#416385

Merged
happysalada merged 3 commits intoNixOS:masterfrom
conroy-cheers:update-vllm-091
Jun 18, 2025
Merged

python312Packages.vllm: 0.9.0.1 -> 0.9.1#416385
happysalada merged 3 commits intoNixOS:masterfrom
conroy-cheers:update-vllm-091

Conversation

@conroy-cheers
Copy link
Copy Markdown
Contributor

@conroy-cheers conroy-cheers commented Jun 13, 2025

Things done

Update python312Packages.vllm to v0.9.1
python312Packages.xgrammar: 0.1.14 -> 0.1.19
python312Packages.py-libnuma: init at 1.2

The substituteInPlace call previously used to disable nccl on unsupported platforms broke, and has been replaced with a patch.

Added torch.stdenv.cc to vllm dependencies, as it expects CC to be available for dynamo recompilation at runtime.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 13, 2025
@conroy-cheers
Copy link
Copy Markdown
Contributor Author

Seems to be broken on CPU as doesn't appear to properly handle the optional intel_extension_for_pytorch anymore, when it did in 0.9.0.1.

Still need to test with CUDA.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 13, 2025
@conroy-cheers conroy-cheers force-pushed the update-vllm-091 branch 2 times, most recently from 09f1f90 to ae41f83 Compare June 14, 2025 06:42
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jun 14, 2025
@conroy-cheers conroy-cheers force-pushed the update-vllm-091 branch 2 times, most recently from fa78820 to 778c9c1 Compare June 14, 2025 08:31
@conroy-cheers
Copy link
Copy Markdown
Contributor Author

I was mistaken about being newly broken on CPU - it fails with some configuration options, but seems this was not changed since the last release. Seems to be working OK.

Also tested working on CUDA.

@conroy-cheers conroy-cheers marked this pull request as ready for review June 14, 2025 08:33
@conroy-cheers
Copy link
Copy Markdown
Contributor Author

cc @happysalada @CertainLach

@conroy-cheers conroy-cheers force-pushed the update-vllm-091 branch 3 times, most recently from 6c703c9 to 2a25eed Compare June 16, 2025 07:05
@happysalada
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416385
Commit: 2a25eed9f417c313b23fe762b05b768e074f0a60


x86_64-linux

❌ 4 packages failed to build:
  • python313Packages.kserve
  • python313Packages.kserve.dist
  • python313Packages.vllm
  • python313Packages.vllm.dist
✅ 12 packages built:
  • python312Packages.kserve
  • python312Packages.kserve.dist
  • python312Packages.py-libnuma
  • python312Packages.py-libnuma.dist
  • vllm (python312Packages.vllm)
  • vllm.dist (python312Packages.vllm.dist)
  • python312Packages.xgrammar
  • python312Packages.xgrammar.dist
  • python313Packages.py-libnuma
  • python313Packages.py-libnuma.dist
  • python313Packages.xgrammar
  • python313Packages.xgrammar.dist

Error logs: `x86_64-linux`
python313Packages.vllm
    from vllm.config import (BlockSize, CacheConfig, CacheDType, CompilationConfig,
    ...<10 lines>...
                             VllmConfig, get_attr_docs, get_field)
  File "/nix/store/21v5bhx8jr2d2y74346igsqx9945s882-python3.13-vllm-0.9.1/lib/python3.13/site-packages/vllm/config.py", line 238, in 
    @config
     ^^^^^^
  File "/nix/store/21v5bhx8jr2d2y74346igsqx9945s882-python3.13-vllm-0.9.1/lib/python3.13/site-packages/vllm/config.py", line 191, in config
    attr_docs = get_attr_docs(cls)
  File "/nix/store/21v5bhx8jr2d2y74346igsqx9945s882-python3.13-vllm-0.9.1/lib/python3.13/site-packages/vllm/config.py", line 146, in get_attr_docs
    cls_node = ast.parse(textwrap.dedent(inspect.getsource(cls))).body[0]
                                         ~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/2mab9iiwhcqwk75qwvp3zv0bvbiaq6cs-python3-3.13.3/lib/python3.13/inspect.py", line 1258, in getsource
    lines, lnum = getsourcelines(object)
                  ~~~~~~~~~~~~~~^^^^^^^^
  File "/nix/store/2mab9iiwhcqwk75qwvp3zv0bvbiaq6cs-python3-3.13.3/lib/python3.13/inspect.py", line 1240, in getsourcelines
    lines, lnum = findsource(object)
                  ~~~~~~~~~~^^^^^^^^
  File "/nix/store/2mab9iiwhcqwk75qwvp3zv0bvbiaq6cs-python3-3.13.3/lib/python3.13/inspect.py", line 1089, in findsource
    raise OSError('source code not available')
OSError: source code not available

@conroy-cheers
Copy link
Copy Markdown
Contributor Author

Should probably disable for python313: vllm-project/vllm#12083

@happysalada happysalada merged commit a4421c3 into NixOS:master Jun 18, 2025
14 of 16 checks passed
@conroy-cheers conroy-cheers deleted the update-vllm-091 branch June 18, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants