[25.05] workflows/reviewers: actually ping maintainers when undrafting#416398
Merged
wolfgangwalther merged 3 commits intoNixOS:release-25.05from Jun 13, 2025
Merged
Conversation
This forces better error handling as described in [1]. Without this change, bash would *not* run with `-o pipefail`, which means some errors go unnoticed. By naming `bash` explicitly, `-o pipefail` is enabled. 1: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#defaultsrunshell (cherry picked from commit 0f5e504)
To actually download the eval results and then proceed to ping maintainers after undrafting, the run-id must be specified explicitly. Because we didn't run with `-o pipefail` up to the last commit, we didn't notice that this workflow was silently failing with this error: jq: error: Could not open file comparison/maintainers.json: No such file or directory (cherry picked from commit 530f896)
We are using a concurrency group by now. (cherry picked from commit 07173e1)
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
philiptaron,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #415680, because NixOS/org#125 is not resolved, yet.