modular-services: merge process.argv from executable and args#424881
Merged
roberth merged 2 commits intomodular-servicesfrom Jul 19, 2025
unknown repository
Merged
modular-services: merge process.argv from executable and args#424881roberth merged 2 commits intomodular-servicesfrom unknown repository
roberth merged 2 commits intomodular-servicesfrom
unknown repository
Conversation
github-actions
bot
added
6.topic: nixos
nixpkgs-ci
bot
added
the
12.first-time contribution
roberth
reviewed
Jul 13, 2025
Member
There was a problem hiding this comment.
I don't think I should have used programOrStr for anything but the executable. It overloads string coercion and that's surprising. (my fault)
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Member
|
This will merge into a feature branch.
|
nixpkgs-ci
bot
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of the change proposed at #372170 (comment)
Ping @roberth