redo-apenwarr: Fix failure with bash-5.3 #429699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used --replace is deprecated.
The failure manifests as:
minimal/do: line 358: cd: null directory
In bash 5.3, command "cd ''" fails, while in the previous bash version
it succeeds and no directory is changed. In the fix, we replace empty
"$dodir" with ".".
Context:
- apenwarr/redo#47
- https://cgit.git.savannah.gnu.org/cgit/bash.git/tree/CHANGES?h=bash-5.3#n119.
- https://lists.gnu.org/archive/html/bug-bash/2025-07/msg00152.html
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
Author
|
Closed/reopened in an attempt to get rid of |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure manifests as:
(see https://hydra.nixos.org/build/303454733/nixlog/1)
In bash 5.3, command
cd ''fails, while in the previous bash version it succeeds and no directory is changed. In the fix, we replace empty$dodirwith..Context:
When at it, this also updates deprecated
substituteInPlacearguments.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.