Skip to content

nexusmods-app: 0.14.3 -> 0.15.2#433654

Merged
MattSturgeon merged 8 commits intoNixOS:masterfrom
MattSturgeon:nexus-0.15
Aug 20, 2025
Merged

nexusmods-app: 0.14.3 -> 0.15.2#433654
MattSturgeon merged 8 commits intoNixOS:masterfrom
MattSturgeon:nexus-0.15

Conversation

@MattSturgeon
Copy link
Copy Markdown
Contributor

@MattSturgeon MattSturgeon commented Aug 14, 2025 •
edited
Loading

Changelog: https://github.com/Nexus-Mods/NexusMods.App/releases/tag/v0.15.2

This release is a bit complicated, because upstream have added some build dependencies fetched from the internet at build time by the csproj project files.

We need to patch these out and/or replace them with pinned versions.

I've added a pinned game_hashes_db input and a vendored games.json input. Both of these have update scripts, which are also run by nexusmods-app.updateScript.

Having fixed versions of these inputs available at build time also means we can re-enable most of the test suite.

I'd appreciate reviews from anyone familiar with update scripts.

This release also introduces a generated buildDate.txt file, so I've overridden it with the unix epoch to improve build reproducibility. I haven't tested if this fully resolves the package's build reproducibility issues, yet.

Additionally, when testing the exe I am seeing OAuth exceptions which need further investigation. (seems to have resolved itself)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Aug 14, 2025
@MattSturgeon MattSturgeon force-pushed the nexus-0.15 branch 5 times, most recently from f55f7ed to a1f7331 Compare August 15, 2025 20:30
@MattSturgeon MattSturgeon marked this pull request as ready for review August 15, 2025 20:33
@MattSturgeon

This comment was marked as outdated.

Sign in to view
MattSturgeon
MattSturgeon commented Aug 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues I've spotted:

I'll address these later as I'm out of time for tonight.

(Others feel free to review in the meantime)

@MattSturgeon MattSturgeon requested a review from corngood August 16, 2025 21:28
corngood
corngood reviewed Aug 18, 2025
View reviewed changes
corngood
corngood reviewed Aug 18, 2025
View reviewed changes
@MattSturgeon
nexusmods-app: fix changelog URL
62602e6 
This was broken when switching from `fetchFromGitHub` to `fetchgit` in
cd8b3d6
@MattSturgeon
nexusmods-app: 0.14.3 → 0.15.2
0f6de01 
https://github.com/Nexus-Mods/NexusMods.App/releases/tag/v0.15.2

We now need to patch or remove dynamic build dependencies, including
`games.json` and `game_hashes_db.zip`.
@MattSturgeon
nexusmods-app: use a fixed build date
a5e5bad 
Improve build reproducibility by specifying a fixed build date
(the unix epoch).
@MattSturgeon
nexusmods-app: pin game hashes db
3dd829f
@MattSturgeon
nexusmods-app: vendor games.json
9f7f36f 
Subset of https://data.nexusmods.com/file/nexus-data/games.json
@MattSturgeon
nexusmods-app: init update script for vendored files
f4ae5d4 
Currently, the only vendored file is games.json
@MattSturgeon
nexusmods-app: init update script for game_hashes_db
ee180d4
@MattSturgeon
nexusmods-app: wrap the update scripts
ba60a12
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 20, 2025
@MattSturgeon
Copy link
Copy Markdown
Contributor Author

MattSturgeon commented Aug 20, 2025 •
edited
Loading

Thanks @corngood for your feedback and approval 🫶

Before merging, I'd ideally like to see:

  • ofborg build nexusmods-app.tests
  • nixpkgs-review
    • x86_64-linux
    • aarch64-linux
  • ACK from co-maintainers (@l0b0)
  • ACK from upstream (e.g. @Sewer56)
    • In particular, regarding us vendering a subset of games.json

@MattSturgeon
Copy link
Copy Markdown
Contributor Author

MattSturgeon commented Aug 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 433654
Commit: ba60a124f4adbf527b61a6171c6850b488f6ea0c (subsequent changes)
Merge: 715a687caac1164c6a776153a368b49eb4038ed1

Logs: https://github.com/MattSturgeon/nixpkgs-review-gha/actions/runs/17101263489

x86_64-linux

✅ 2 packages built:
  • nexusmods-app
  • nexusmods-app-unfree

aarch64-linux

✅ 2 packages built:
  • nexusmods-app
  • nexusmods-app-unfree

@Sewer56
Copy link
Copy Markdown
Contributor

Sewer56 commented Aug 20, 2025 •
edited
Loading

(I'll poke around at the end of the day)

I was asked the other week about vendoring a subset of the data- that's fine. At runtime, the App will resolve games it doesn't know- the vendored info is purely for speeding up initial startup.

@Sewer56
Copy link
Copy Markdown
Contributor

Sewer56 commented Aug 20, 2025

Looks good to me.
I didn't scrutinise extremely intently; only the surface level parts- but appears to be good to me.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 20, 2025
l0b0
l0b0 approved these changes Aug 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MattSturgeon
Copy link
Copy Markdown
Contributor Author

MattSturgeon commented Aug 20, 2025 •
edited
Loading

Ofborg seems stalled on reporting back for aarch64-linux, but looking at its logs it has successfully built nexusmods-app.tests on aarch64-linux at least once: https://logs.ofborg.org/?attempt_id=f7595152-7216-44a8-b8ca-3275fae75fde&key=nixos%2Fnixpkgs.433654

I'm happy enough. Thanks everyone ❤️

@MattSturgeon MattSturgeon merged commit 1c53d4b into NixOS:master Aug 20, 2025
27 of 30 checks passed
@MattSturgeon MattSturgeon deleted the nexus-0.15 branch August 20, 2025 16:36
@Sewer56
Copy link
Copy Markdown
Contributor

Sewer56 commented Aug 20, 2025 •
edited
Loading

(I actually don't even know if App even boots up on aarch64 , it's never been tested by anyone, funnily enough.)
(There was a small bit of macOS work by halgari last year, but never fully finished)

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Aug 20, 2025
This was referenced Sep 30, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corngood corngood corngood approved these changes

@khaneliman khaneliman Awaiting requested review from khaneliman

+2 more reviewers

@Sewer56 Sewer56 Sewer56 approved these changes

@l0b0 l0b0 l0b0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MattSturgeon @Sewer56 @l0b0 @corngood