workflows/codeowners: move into PR workflow#434555
Merged
wolfgangwalther merged 5 commits intoNixOS:masterfrom Aug 20, 2025
Merged
workflows/codeowners: move into PR workflow#434555wolfgangwalther merged 5 commits intoNixOS:masterfrom
wolfgangwalther merged 5 commits intoNixOS:masterfrom
Conversation
nix-owners
bot
requested review from
MattSturgeon,
Mic92,
philiptaron and
zowoq
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
wolfgangwalther
force-pushed
the
ci-pr-owners
branch
from
e4d25e3 to
33dc022
Compare
wegank
added
the
2.status: merge conflict
Preparation to split the whole file.
Allows splitting the workflow file in the next step.
This runs the "check owners" job as part of the main PR workflow, with multiple advantages: - The job doesn't run anymore when undrafting a PR, where it's not required, because the OWNERS file's contents didn't change. - A valid OWNERS file is now a requirement to merge a PR. - The OWNERS file is always checked on the exact same test merge commit that the remainder of the workflows are running on as well.
Changes to this file already trigger a run of this workflow via the PR workflow, we don't need to run this *another* time.
These two jobs mostly used the same code anyway, so they can easily run in the same job. This uses fewer resources and avoids running (and failing) the codeowners review job on Pull Requests from development branches like staging-next or haskell-updates. It also opens the door for more improvements later on, for example it will be much easier to implement a shared reviewer limit for both owners and maintainers now.
wolfgangwalther
force-pushed
the
ci-pr-owners
branch
from
33dc022 to
ddf81de
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
MattSturgeon
approved these changes
Aug 20, 2025
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
Reading through each commits' diff, I can't see any issues. I also agree with the motivation of the PR.
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
Author
|
Will have to double check that both workflows work fine after merge - can't fully test these in a fork, because all the codeowners are not part of my user's org. |
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
Contributor
Author
Worked fine in #435302. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the codeowners workflow into the main PR workflow with the following advantages:
checkjob doesn't run anymore when undrafting a PR, where it's not required, because the OWNERS file's contents didn't change.Also the code structure is cleaner, because everything runs through the PR workflow.
This will delay the review of codeowners until Eval has run. Whether that's good or bad or just different is probably just a matter of opinion.
Things done
Add a 👍 reaction to pull requests you find important.