Conversation
|
Thanks and congratulations on your first contribution to Nixpkgs! Per CONTRIBUTING.MD we should squash the second commit into the first in order to separate each logical change as well as to conform to the commit message standard. |
5308ce5 to
94c087f
Compare
|
I don't think that we need the update script as the updates worked with the bots. |
94c087f to
d9f2a23
Compare
Thanks! Updated to remove the updateScript |
06kellyjac
left a comment
There was a problem hiding this comment.
Thanks. 🚀
There's an eval failure for dawin but that looks like GH Actions's fault. Hopefully someone can trigger a restart.
|
@andrewg-xyz rebase with master and force push, that could fix the failing github actions. |
|
I've manually restarted the failed jobs. Hopefully no failures this time. |
d9f2a23 to
3f05741
Compare
|
3f05741 to
54bcda1
Compare
Was this intended to be added? There isn't a change related to this in this PR. |
Originally I had included the |
pkgs/by-name/gr/grype/package.nixto latest available 0.98.0, which includes skipping a failing CycloneDX testThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.