Skip to content

radicle-node: use canonical release reference, add updateScript, modernize, adopt#435071

Merged
Defelo merged 7 commits intoNixOS:masterfrom
Defelo:push-xpptvmtlrvxu
Aug 22, 2025
Merged

radicle-node: use canonical release reference, add updateScript, modernize, adopt#435071
Defelo merged 7 commits intoNixOS:masterfrom
Defelo:push-xpptvmtlrvxu

Conversation

@Defelo
Copy link
Copy Markdown
Member

@Defelo Defelo commented Aug 19, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Defelo Defelo force-pushed the push-xpptvmtlrvxu branch from 25f4e79 to 4e779d5 Compare August 19, 2025 19:19
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 8.has: documentation This PR adds or changes documentation labels Aug 19, 2025
@Defelo Defelo force-pushed the push-xpptvmtlrvxu branch from 4e779d5 to 3958233 Compare August 20, 2025 13:29
@Defelo Defelo force-pushed the push-xpptvmtlrvxu branch from 3958233 to 3c652b8 Compare August 22, 2025 05:54
@Defelo Defelo removed 8.has: documentation This PR adds or changes documentation 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) labels Aug 22, 2025
@Defelo
Copy link
Copy Markdown
Member Author

Defelo commented Aug 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 435071 -a radicle-node.tests
Commit: 3c652b8aa9820890a453f520419921b921db0214 (subsequent changes)
Merge: 328e3b5d71887ae318cdc5c96f96ebe08791a8b9

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/17147390659

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-435071-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/4m27dm2bfvp669p1ncs0gjl60gs2ppkr-radicle-node-1.3.0 \
  /nix/store/ciylkhbc08awdkdbas31qv3xl0ghvwpl-radicle-node-1.3.0-basic-test \
  /nix/store/i9cdvh9afp5jd7rcngkric9ird8805aa-config.json \
  /nix/store/8gsy70zs85a0qhy2s3l4j8scp6gw0dzl-config.json \
  /nix/store/h4by7rs1sd4lraw0y28w7iblp52a8n1h-vm-test-run-radicle \
  /nix/store/d42i6pp262xm9rba5paczvgjq6csz7x8-radicle-tui-0.6.0
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-435071-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/cryh6sgd62n01a93jwx3i5pkn1gdxxz1-radicle-node-1.3.0 \
  /nix/store/jl654prgavsfikyiqjgjiiq1pn6x2glb-radicle-node-1.3.0-basic-test \
  /nix/store/ns5jipb57xj46ln1498izsdjcgnbli5j-config.json \
  /nix/store/9nqs3g85m4pa4y57akg5ny624mrww5s5-config.json \
  /nix/store/r9gp6w90i6i0pf18mzr7q5r713sl37kq-radicle-tui-0.6.0
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-435071-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/kih8pvcr9g9dlbs6624rmjdbkpb8q5zb-radicle-node-1.3.0 \
  /nix/store/9j71nfsgzszr4r5xmwbrz3l8p2biakjv-radicle-node-1.3.0-basic-test \
  /nix/store/bnrwh61k00sx599vz7afd9xd7siyribj-config.json \
  /nix/store/42q5j9za76jfip6v1qar65h0lsymz491-radicle-tui-0.6.0

x86_64-linux

✅ 6 packages built:
  • radicle-node
  • radicle-node.tests.basic
  • radicle-node.tests.nixos-build.checkConfig-failure
  • radicle-node.tests.nixos-build.checkConfig-success
  • radicle-node.tests.nixos-run
  • radicle-tui

aarch64-linux

✅ 5 packages built:
  • radicle-node
  • radicle-node.tests.basic
  • radicle-node.tests.nixos-build.checkConfig-failure
  • radicle-node.tests.nixos-build.checkConfig-success
  • radicle-tui
❔ 1 package not supported by the current system:
  • radicle-node.tests.nixos-run

x86_64-darwin (sandbox = true)

❌ 1 package still failing to build (also failed on master):
  • radicle-node.tests.nixos-build.checkConfig-success
✅ 4 packages built:
  • radicle-node
  • radicle-node.tests.basic
  • radicle-node.tests.nixos-build.checkConfig-failure
  • radicle-tui
❔ 1 package not supported by the current system:
  • radicle-node.tests.nixos-run

aarch64-darwin (sandbox = true)

❌ 1 package still failing to build (also failed on master):
  • radicle-node.tests.nixos-build.checkConfig-success
✅ 4 packages built:
  • radicle-node
  • radicle-node.tests.basic
  • radicle-node.tests.nixos-build.checkConfig-failure
  • radicle-tui
❔ 1 package not supported by the current system:
  • radicle-node.tests.nixos-run

@Defelo Defelo marked this pull request as ready for review August 22, 2025 06:30
@nix-owners nix-owners bot requested review from amesgen and lorenzleutgeb August 22, 2025 06:32
@lorenzleutgeb
Copy link
Copy Markdown
Member

lorenzleutgeb commented Aug 22, 2025

Wow! What a nice touch up! Thanks a lot! 🙌🏻

amesgen
amesgen approved these changes Aug 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 22, 2025
@Defelo Defelo force-pushed the push-xpptvmtlrvxu branch from 3c652b8 to 6203ba7 Compare August 22, 2025 18:32
@lorenzleutgeb
Copy link
Copy Markdown
Member

lorenzleutgeb commented Aug 22, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 435071

Logs: https://github.com/lorenzleutgeb/nixpkgs-review-gha/actions/runs/17163645152

x86_64-linux

✅ 2 packages built:
  • radicle-node
  • radicle-tui

aarch64-linux

✅ 2 packages built:
  • radicle-node
  • radicle-tui

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • radicle-node
  • radicle-tui

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • radicle-node
  • radicle-tui

lorenzleutgeb
lorenzleutgeb approved these changes Aug 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lorenzleutgeb lorenzleutgeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 22, 2025
@Defelo Defelo merged commit cc17aa2 into NixOS:master Aug 22, 2025
26 of 28 checks passed
@Defelo Defelo deleted the push-xpptvmtlrvxu branch August 22, 2025 22:00
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Aug 22, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Aug 22, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lorenzleutgeb lorenzleutgeb lorenzleutgeb approved these changes

@amesgen amesgen amesgen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Defelo @lorenzleutgeb @amesgen