ci/treefmt: add biome#435259
Merged
wolfgangwalther merged 7 commits intoNixOS:masterfrom Aug 20, 2025
Merged
Conversation
1 task
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
JS looks good, not convinced about the CSS indentation though.
ci/default.nix
Outdated
Contributor
There was a problem hiding this comment.
Interesting that this apparently doesn't need pkgs/**?
Makes me wonder if this is actually matching any part of the path (effectively **/pkgs/*/**, with the leading **/ and trailing /** added implicitly by treefmt)?
If so, I'd expect pkgs to work without any /* needed.
cc @jfly @brianmcgee
Contributor
Author
There was a problem hiding this comment.
If so, I'd expect
pkgsto work without any/*needed.
Tested: Nope, it doesn't.
wolfgangwalther
force-pushed
the
ci-treefmt-biome
branch
from
cc872e3 to
590b4c5
Compare
This excludes doc and pkgs folders, because there are way too many files to fix at the moment.
We already do in doc/style.css, but we should tell our editors and formatters, too. The comment.. doesn't really make sense, it's purely repetitive with the code itself. Thus, removed.
wolfgangwalther
force-pushed
the
ci-treefmt-biome
branch
from
590b4c5 to
f668934
Compare
MattSturgeon
approved these changes
Aug 20, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
This comment was marked as resolved.
This comment was marked as resolved.
wolfgangwalther
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds biome as a formatter, for now only for everything except
pkgs/*. There are too many files to go through in there, right now.Avoids formatting for the CI scripts from getting out of sync all the time, see #434541 (comment).
Things done
Add a 👍 reaction to pull requests you find important.