Closed
Conversation
aae8316 to
6e3ce68
Compare
Contributor
Author
|
Contributor
Author
|
Considering that accounts migrated to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
runeliteto version2.7.5and added myself to maintainers .To update from 2.7.2 it was necessary to switch from Maven to Gradle so I switched the derivation over to the new Gradle builder described in the nixpkgs docs.
This update was made based on information from https://github.com/runelite/launcher/releases/
This is my second time contributing and my first time doing a version bump that involves more than version and hash updates so any feedback and review is appreciated, it is building and running fine in my system but I'm sure more experienced reviewers will know if I missed something, constructive feedback is always welcome as I learn more Nix.
Thank you!
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.