Skip to content

cctv-viewer: 0.1.9-unstable-2025-06-13 -> 0.1.9-dev#435266

Open
teohz wants to merge 1 commit intoNixOS:masterfrom
teohz:cctv-viewer-update-to-tag
Open

cctv-viewer: 0.1.9-unstable-2025-06-13 -> 0.1.9-dev#435266
teohz wants to merge 1 commit intoNixOS:masterfrom
teohz:cctv-viewer-update-to-tag

Conversation

@teohz
Copy link
Copy Markdown
Contributor

@teohz teohz commented Aug 20, 2025

This updates the cctv-viewer package to use a newly created upstream tag (0.1.9-dev) instead of a raw commit hash.

This provides a more stable and permanent reference for the package source, following a recommendation from the initial package review.
The description has been updated to be more descriptive and mirror the official one.
The underlying source code is the same.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
    • [NixOS tests] in [nixos/tests].
    • [Package tests] at passthru.tests.
    • Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
  • Ran nixpkgs-review on this PR. See [nixpkgs-review usage].
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 20, 2025
@teohz
Copy link
Copy Markdown
Contributor Author

teohz commented Aug 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 435266
Commit: e5a680a91ead3759095f583e975dafda297c6a49


x86_64-linux

✅ 1 package built:
  • cctv-viewer

Copy link
Copy Markdown
Contributor Author

@teohz teohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 1, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 10, 2025

meta = {
description = "Viewer and mounter for video streams";
description = "A simple Qt application for simultaneously viewing multiple video streams. Designed for high performance and low latency. Based on ffmpeg.";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description must not start with an article and be a single sentence, see here. You can use longDescription if you want to write more.

Suggested change
description = "A simple Qt application for simultaneously viewing multiple video streams. Designed for high performance and low latency. Based on ffmpeg.";
description = "Simple Qt application for simultaneously viewing multiple video streams";

owner = "iEvgeny";
repo = "cctv-viewer";
rev = "8a8fff2612ae2123b8be156c954a29706383b480";
rev = "v${version}";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v${version}";
tag = "v${version}";

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants