Skip to content

spoolman: init service#435272

Merged
Lassulus merged 3 commits intoNixOS:masterfrom
MayNiklas:init-spoolman-service
Sep 2, 2025
Merged

spoolman: init service#435272
Lassulus merged 3 commits intoNixOS:masterfrom
MayNiklas:init-spoolman-service

Conversation

@MayNiklas
Copy link
Copy Markdown
Member

Adds a module for Spoolman to NixPkgs.
Spoolman is an inventory management system for 3D printer filaments.
Spoolman itself is already in NixPkgs, but it did not have a module for simplified deployment yet.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@MayNiklas MayNiklas requested a review from pinpox August 20, 2025 14:13
@MayNiklas MayNiklas force-pushed the init-spoolman-service branch from 33feef0 to 4f71287 Compare August 20, 2025 14:18
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation labels Aug 20, 2025
@MayNiklas MayNiklas force-pushed the init-spoolman-service branch from 4f71287 to 977c55d Compare August 20, 2025 20:39
@MayNiklas MayNiklas marked this pull request as ready for review August 20, 2025 20:39
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 20, 2025

enable = lib.mkEnableOption "Spoolman, a filament spool inventory management system.";

environment = lib.mkOption {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more examples and a link to upstream documentation would be helpful here, otherwise it feels a bit redundant to using systemd.services.spoolman.environment directly

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more examples and a link to upstream documentation would be helpful here, otherwise it feels a bit redundant to using systemd.services.spoolman.environment directly

You got a point!
I've added an example as well as a link to the documentation.

If you still find it redundant, I will remove services.spoolman.environment.

Thank you!!

@Lassulus Lassulus merged commit 71acfb3 into NixOS:master Sep 2, 2025
29 of 31 checks passed
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants