Skip to content

mame: remove coreaudio_sound.cpp patch (upstreamed)#435273

Merged
NickCao merged 1 commit intoNixOS:masterfrom
Rhys-T:remove-mame-darwin-patch
Aug 21, 2025
Merged

mame: remove coreaudio_sound.cpp patch (upstreamed)#435273
NickCao merged 1 commit intoNixOS:masterfrom
Rhys-T:remove-mame-darwin-patch

Conversation

@Rhys-T
Copy link
Copy Markdown
Contributor

@Rhys-T Rhys-T commented Aug 20, 2025

This patch is no longer needed after the most recent update (#431692), and is breaking macOS/Darwin builds (x86-64, aarch64).

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 20, 2025
This patch is no longer needed after the most recent update, and is
breaking macOS/Darwin builds.
@Rhys-T Rhys-T force-pushed the remove-mame-darwin-patch branch from dbbce73 to 05a8753 Compare August 20, 2025 14:26
@NickCao NickCao merged commit c13da9e into NixOS:master Aug 21, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants