nixosTests.prometheus-exporters.smokeping: fix test after 0.10.0#435285
Merged
lukegb merged 1 commit intoNixOS:masterfrom Aug 21, 2025
Merged
nixosTests.prometheus-exporters.smokeping: fix test after 0.10.0#435285lukegb merged 1 commit intoNixOS:masterfrom
lukegb merged 1 commit intoNixOS:masterfrom
Conversation
prometheus-smokeping-prober was updated to 0.10.0 in NixOS#396980 which introduced a new label `tos` in its metrics. add it to the failing tests to make them match the expected metric (and pass) again you could argue that the tests are a bit too greedy with the way they match metrics, but I actually like it that way
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Erethon
approved these changes
Aug 20, 2025
Contributor
Erethon
left a comment
Erethon
left a comment
There was a problem hiding this comment.
Makes sense to me, tested on NixOS and can confirm that tests were broken but now pass.
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
|
Successfully created backport PR for |
Merged
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prometheus-smokeping-prober was updated to 0.10.0 in #396980 which introduced a new label
tosin its metrics. add it to the failing tests to make them match the expected metric (and pass) againyou could argue that the tests are a bit too greedy with the way they match metrics, but I actually like it that way
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.