Skip to content

[Backport release-25.05] workflows/codeowners: move into PR workflow#435298

Merged
wolfgangwalther merged 5 commits intorelease-25.05from
backport-434555-to-release-25.05
Aug 20, 2025
Merged

[Backport release-25.05] workflows/codeowners: move into PR workflow#435298
wolfgangwalther merged 5 commits intorelease-25.05from
backport-434555-to-release-25.05

Conversation

@nixpkgs-ci
Copy link
Copy Markdown
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Aug 20, 2025

Bot-based backport to release-25.05, triggered by a label in #434555.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-committer, if you find that it is not acceptable, leave a comment.

Preparation to split the whole file.

(cherry picked from commit c962461)
Allows splitting the workflow file in the next step.

(cherry picked from commit 368a2d6)
This runs the "check owners" job as part of the main PR workflow, with
multiple advantages:
- The job doesn't run anymore when undrafting a PR, where it's not
required, because the OWNERS file's contents didn't change.
- A valid OWNERS file is now a requirement to merge a PR.
- The OWNERS file is always checked on the exact same test merge commit
that the remainder of the workflows are running on as well.

(cherry picked from commit 15be04f)
Changes to this file already trigger a run of this workflow via the PR
workflow, we don't need to run this *another* time.

(cherry picked from commit 7f4dd7e)
These two jobs mostly used the same code anyway, so they can easily run
in the same job. This uses fewer resources and avoids running (and
failing) the codeowners review job on Pull Requests from development
branches like staging-next or haskell-updates.

It also opens the door for more improvements later on, for example it
will be much easier to implement a shared reviewer limit for both owners
and maintainers now.

(cherry picked from commit ddf81de)
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 4.workflow: backport This targets a stable branch 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels Aug 20, 2025
@wolfgangwalther wolfgangwalther merged commit 07e771b into release-25.05 Aug 20, 2025
50 of 54 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-434555-to-release-25.05 branch August 20, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant