[Backport release-25.05] workflows/codeowners: move into PR workflow#435298
Merged
wolfgangwalther merged 5 commits intorelease-25.05from Aug 20, 2025
Merged
[Backport release-25.05] workflows/codeowners: move into PR workflow#435298wolfgangwalther merged 5 commits intorelease-25.05from
wolfgangwalther merged 5 commits intorelease-25.05from
Conversation
Preparation to split the whole file. (cherry picked from commit c962461)
Allows splitting the workflow file in the next step. (cherry picked from commit 368a2d6)
This runs the "check owners" job as part of the main PR workflow, with multiple advantages: - The job doesn't run anymore when undrafting a PR, where it's not required, because the OWNERS file's contents didn't change. - A valid OWNERS file is now a requirement to merge a PR. - The OWNERS file is always checked on the exact same test merge commit that the remainder of the workflows are running on as well. (cherry picked from commit 15be04f)
Changes to this file already trigger a run of this workflow via the PR workflow, we don't need to run this *another* time. (cherry picked from commit 7f4dd7e)
These two jobs mostly used the same code anyway, so they can easily run in the same job. This uses fewer resources and avoids running (and failing) the codeowners review job on Pull Requests from development branches like staging-next or haskell-updates. It also opens the door for more improvements later on, for example it will be much easier to implement a shared reviewer limit for both owners and maintainers now. (cherry picked from commit ddf81de)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-25.05, triggered by a label in #434555.